[igt-dev] [PATCH i-g-t] tests/intel/xe_debugfs: Check tile_count info

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Sep 22 11:53:49 UTC 2023


Hi Rahul,

LGTM,
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

On 2023-09-22 at 17:11:30 +0530, janga.rahul.kumar at intel.com wrote:
> From: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
> 
> Check correctness of tile_count info.
> 
> v2: Use snprintf.(kamil)
------------------- ^
Please use capital letter as first: Kamil

> 
> v3: Add size param. (kamil)
------------------- ^
Same here.

Regards,
Kamil

> 
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Cc: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> Reviewed-by: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
> ---
>  tests/intel/xe_debugfs.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/intel/xe_debugfs.c b/tests/intel/xe_debugfs.c
> index 88b51dbd4..e5bbb364c 100644
> --- a/tests/intel/xe_debugfs.c
> +++ b/tests/intel/xe_debugfs.c
> @@ -13,7 +13,7 @@
>   */
>  
>  #include "igt.h"
> -
> +#include "igt_sysfs.h"
>  #include "xe_drm.h"
>  #include "xe/xe_ioctl.h"
>  #include "xe/xe_query.h"
> @@ -117,6 +117,9 @@ test_base(int fd, struct drm_xe_query_config *config)
>  		igt_assert(igt_debugfs_search(fd, "info", reference));
>  	}
>  
> +	snprintf(reference, sizeof(reference), "tile_count %d", xe_sysfs_get_num_tiles(fd));
> +	igt_assert(igt_debugfs_search(fd, "info", reference));
> +
>  	igt_assert(igt_debugfs_exists(fd, "gt0", O_RDONLY));
>  	if (config->info[XE_QUERY_CONFIG_GT_COUNT] > 1)
>  		igt_assert(igt_debugfs_exists(fd, "gt1", O_RDONLY));
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list