[igt-dev] [PATCH i-g-t 2/3] lib/drmtest: add multigpu helpers

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Tue Sep 26 05:41:48 UTC 2023


On Mon, Sep 25, 2023 at 10:30:17PM +0200, Zbigniew Kempczyński wrote:

<cut>

> > +	if (_multigpu_count < 2) {
> > +		igt_debug("Multigpu prepare failed, no multi-gpu board or no --device nor IGT_DEVICE used\n");
> 
> I think 'no multi-gpu board _AND_ no --device...' should be used here.
> I've tried to run ./xe_create without passing IGT_DEVICE and I've failed.
> I think as you're require chipset you should handle legacy (iterating)
> device opening (one by one which matches chipset).

I was thinking about above and from the logic point of view is correct
(I mean _OR_). But I would rephrase it to sth like: "Multigpu prepare
failed. Ensure IGT_DEVICE is passed and board is multi-gpu".

--
Zbigniew


More information about the igt-dev mailing list