[igt-dev] [PATCH] tests/kms_setmode: Add info as comment for valid scenario

Sharma, Swati2 swati2.sharma at intel.com
Tue Sep 26 05:58:30 UTC 2023


Please change subject to "Add comment for valid scenario"

Remaining LGTM

Reviewed-by: Swati Sharma <swati2.sharma at intel.com>

On 22-Sep-23 8:49 PM, Jeevan B wrote:
> Describe the valid scenario for 'basic-clone-single-crtc' and
> 'basic-clone-single-crtc' tests, as these tests are skipped if
> a valid scenario is not found, which can cause confusion during
> bug analysis.
> 
> Signed-off-by: Jeevan B <jeevan.b at intel.com>
> cc: Swati Sharma <swati2.sharma at intel.com>
> ---
>   tests/kms_setmode.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> index 32a6fb690..a669cc1df 100644
> --- a/tests/kms_setmode.c
> +++ b/tests/kms_setmode.c
> @@ -979,6 +979,14 @@ const char *help_str =
>   	"  -t <test id>\tRun only the test with this id\n"
>   	"  -e \t\tExtend to run on all pipes. (By default tests will run on two pipes only)\n";
>   
> +/*
> + * basic-clone-single-crtc allows the use of a single CRTC for two connectors, such as VGA/HDMI,
> + * VGA/DP, and HDMI/HDMI, which are the possible combinations. Similarly, for invalid-clone-exclusive-crtc,
> + * when a connector uses a CRTC that is not compatible with the connector, for instance, DP/HDMI
> + * can be used on certain pipes on old platforms.
> + */
> +
> +
>   igt_main_args("det:", NULL, help_str, opt_handler, NULL)
>   {
>   	const struct {


More information about the igt-dev mailing list