[igt-dev] [PATCH i-g-t 04/14] benchmarks/gem_wsim: fix duration range check

[Tvrtko Ursulin]

On 26/09/2023 09:44, Marcin Bernatowicz wrote:
> When scale duration (-f) command line option is provided,
> the max duration check does not take it into account, fix it.
> 
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz at linux.intel.com>
> ---
>   benchmarks/gem_wsim.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
> index 65061461d..4f0deb095 100644
> --- a/benchmarks/gem_wsim.c
> +++ b/benchmarks/gem_wsim.c
> @@ -1148,7 +1148,7 @@ parse_workload(struct w_arg *arg, unsigned int flags, double scale_dur,
>   				if (sep && *sep == '-') {
>   					tmpl = strtol(sep + 1, NULL, 10);
>   					check_arg(tmpl <= 0 ||
> -						tmpl <= step.duration.min ||
> +						__duration(tmpl, scale_dur) <= step.duration.min ||

Right!

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

>   						tmpl == LONG_MIN ||
>   						tmpl == LONG_MAX,
>   						"Invalid duration range at step %u!\n",

Could improve the error message with 's/duration range/maximum 
duration/' while at it if you want.

Regards,

Tvrtko