[igt-dev] [PATCH] tests/kms_rmfb: Add check for xe driver

Garg, Nemesa nemesa.garg at intel.com
Tue Sep 26 12:02:58 UTC 2023



> -----Original Message-----
> From: Sharma, Swati2 <swati2.sharma at intel.com>
> Sent: Tuesday, September 26, 2023 3:58 PM
> To: Garg, Nemesa <nemesa.garg at intel.com>; igt-dev at lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH] tests/kms_rmfb: Add check for xe driver
> 
> Also, add closes tag in the commit.
> 
> On 26-Sep-23 3:56 PM, Sharma, Swati2 wrote:
> > Hi Nemesa,
> >
> > Can you please add this test in fast-feedback and add as HAX patch, to
> > check CI results.

Hi Swati,

Thanks for review. I'll do these changes.
> >
> > On 22-Sep-23 9:43 PM, Nemesa Garg wrote:
> >> As the xe check is missing the value of open_count variable is not
> >> incrementing and because of this during drm_close_driver operation
> >> based on open_count value mutex is acquired and there is a callback
> >> to lastclose function.
> >>
> >> Signed-off-by: Nemesa Garg <nemesa.garg at intel.com>
> >> ---
> >>   lib/drmtest.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/lib/drmtest.c b/lib/drmtest.c index e1da66c87..99b655680
> >> 100644
> >> --- a/lib/drmtest.c
> >> +++ b/lib/drmtest.c
> >> @@ -649,7 +649,7 @@ int drm_open_driver(int chipset)
> >>        * starting a test and we install an exit handler to wait until
> >>        * idle before quitting.
> >>        */
> >> -    if (is_i915_device(fd)) {
> >> +    if (is_i915_device(fd) || is_xe_device(fd)) {
> >>           if (__sync_fetch_and_add(&open_count, 1) == 0) {
> >>               __cancel_work_at_exit(fd);
> >>               at_exit_drm_fd = drm_reopen_driver(fd);


More information about the igt-dev mailing list