[igt-dev] [PATCH v2] core_getversion: Test for desired device

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Sep 27 16:53:10 UTC 2023


Hi Daniel,
On 2023-09-26 at 09:42:26 -0700, Daniel Stone wrote:
> On Mon, 25 Sept 2023 at 09:22, Rob Clark <robdclark at gmail.com> wrote:
> > +       const char *name = getenv("IGT_REQUIRED_DRIVER");
> >
> > -       fd = drm_open_driver(DRIVER_ANY);
> > +       fd = __drm_open_driver(DRIVER_ANY);
> 
> Shouldn't this try to open the actual driver name? Otherwise we could
> false-fail a test because our 'any driver' picked the wrong device
> when multiple of them are present.

> > -       fd = drm_open_driver(

All kms tests use DRIVER_ANY, what is needed is check later
if DRIVER_ANY actually loaded our driver.

+cc Petri

Regards,
Kamil


More information about the igt-dev mailing list