[PATCH i-g-t 0/8] Refactors and fixes for drm_clients

Lucas De Marchi lucas.demarchi at intel.com
Tue Apr 2 22:17:08 UTC 2024


Some refactors and fixes I did while adding support for
gputop in xe. I will send those later on top, but I think
these can already be reviewed.

Last patch should NOT be applied for now. In my mind the lazy approach
makes total sense and should be faster. But reality doesn't agree with
me and after timing igt_drm_clients_scan() it shows a ~10% slow down.
Hard to explain. Maybe I didn't have enough coffee when benchmarking it. 

I don't like much the strstartswith() with and extra output param.
Maybe changing its name to something else would make it better.

Lucas De Marchi (8):
  lib/igt_drm_clients: Use calloc
  lib/igt_drm_clients: Fix sizeof calculation
  lib/igt_drm_clients: Fix leaks
  gputop: Free clients on exit
  lib/igt_drm_fdinfo: Simplify find_kv()
  lib/igt_drm_fdinfo: Stop passing key twice
  lib/igt_drm_fdinfo: Remove prefix arg from parse functions
  lib/igt_drm_clients: lazy stat process

 lib/igt_drm_clients.c |  74 ++++++++++++-----------
 lib/igt_drm_fdinfo.c  | 137 ++++++++++++++++++++----------------------
 tools/gputop.c        |   2 +
 3 files changed, 108 insertions(+), 105 deletions(-)

-- 
2.43.0



More information about the igt-dev mailing list