[PATCH i-g-t 4/8] gputop: Free clients on exit
Tvrtko Ursulin
tursulin at ursulin.net
Wed Apr 3 16:13:30 UTC 2024
On 02/04/2024 23:17, Lucas De Marchi wrote:
> So it's easily checked with valgrind if we there's something leaking.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
> tools/gputop.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/gputop.c b/tools/gputop.c
> index 71e28f43e..b13044b50 100644
> --- a/tools/gputop.c
> +++ b/tools/gputop.c
> @@ -293,5 +293,7 @@ int main(int argc, char **argv)
> usleep(period_us);
> }
>
> + igt_drm_clients_free(clients);
> +
> return 0;
> }
Indeed.. intel_gpu_top even has it already which makes me think for some
reason I forgot to test with Valgrid when adding memory stats. Strange
becasuse previously when working on these tools I found it
indispensable. Anyway, thanks for fixing it!
Reviewed-by: Tvrtko Ursulin <tursulin at ursulin.net>
Regards,
Tvrtko
More information about the igt-dev
mailing list