[PATCH i-g-t 0/5] Fix name collisions in Core test documentation

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue Apr 9 15:13:09 UTC 2024


Hi Katarzyna,
On 2024-04-09 at 11:19:10 +0000, Katarzyna Piecielska wrote:
> After updating i915 and XE test documentation for Core there is a need to fix
> some name collisions to make our infrastructure happy. These changes are around
> Core tests. To make sure all name collisions were removed I was using
> scripts/doc-tests-cross-check.sh. Remaining collisions are around KMS tests.
> 
> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> 

There are few collisions left, could you also remove them?

Possibly colliding doc words ( cat e.* |sort -u ):
display
obsolete
synchronization

grep -i -E -w display n.*|head
n.Category:../tests/chamelium/kms_chamelium_audio.c: * Category: Display
n.Category:../tests/chamelium/kms_chamelium_color.c: * Category: Display

Collision for 'display' is in one test documentation:

grep -i -E -w display n.Sub*
../tests/intel/i915_selftest.c: * Sub-category: Display

Maybe name it 'Display selftest'? Or create new one sub-category
'driver selftest'?

'Obsolete' is in Category:
grep -i -E -w obsolete n.*
n.Category:../tests/intel/gen3_mixed_blits.c: * Category: Obsolete
n.Category:../tests/intel/gen3_render_linear_blits.c: * Category: Obsolete

So collisions are in two subtests:
n.Functionality:../tests/intel/kms_pipe_b_c_ivb.c: * Functionality: kms_core, obsolete
n.Functionality:../tests/kms_tv_load_detect.c: * Functionality: obsolete

Collision for 'synchronization' is in one doc:
grep -i -E -w synchronization n.*
n.Functionality:../tests/intel/kms_fence_pin_leak.c: * Functionality: kms_core, synchronization

as I ssume this should be Sub-category:
n.Sub-category:../tests/intel/gem_sync.c: * Sub-category: Synchronization
n.Sub-category:../tests/intel/i915_selftest.c: * Sub-category: Synchronization
n.Sub-category:../tests/intel/xe_waitfence.c: * Sub-category: Synchronization
n.Sub-category:../tests/syncobj_basic.c: * Sub-category: Synchronization

Regards,
Kamil

> 
> Katarzyna Piecielska (5):
>   tests/intel: Add missing Sub-category for xe_waitfence
>   tests/intel: Remove name collision in Display tests visible in Core
>     docs
>   tests/intel: Remove documentation collision for Obsolete category
>   tests/intel: Remove documentation collisions in i915_selftest
>   tests: Remove collisions with Subcategory and Functionality
> 
>  tests/dmabuf.c                         |  2 +-
>  tests/dmabuf_sync_file.c               |  2 +-
>  tests/drm_mm.c                         |  2 +-
>  tests/drm_read.c                       |  2 +-
>  tests/intel/gem_exec_endless.c         |  4 ++--
>  tests/intel/gem_exec_params.c          |  4 ++--
>  tests/intel/gem_fence_thrash.c         |  2 +-
>  tests/intel/gem_fence_upload.c         |  2 +-
>  tests/intel/gem_fenced_exec_thrash.c   |  6 +++---
>  tests/intel/gen3_mixed_blits.c         |  4 ++--
>  tests/intel/gen3_render_linear_blits.c |  4 ++--
>  tests/intel/gen3_render_mixed_blits.c  |  4 ++--
>  tests/intel/gen3_render_tiledx_blits.c |  4 ++--
>  tests/intel/gen3_render_tiledy_blits.c |  4 ++--
>  tests/intel/i915_pipe_stress.c         |  2 +-
>  tests/intel/i915_selftest.c            | 24 ++++++++++++------------
>  tests/intel/perf.c                     |  6 +++---
>  tests/intel/prime_mmap_kms.c           |  2 +-
>  tests/intel/xe_exec_compute_mode.c     |  2 +-
>  tests/intel/xe_live_ktest.c            |  6 +++---
>  tests/intel/xe_waitfence.c             |  1 +
>  tests/prime_nv_api.c                   |  2 +-
>  22 files changed, 46 insertions(+), 45 deletions(-)
> 
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list