[PATCH i-g-t 8/9] tests/intel/km_big_joiner: use kmstest_force_connector_debugfs for better cleanup functionality
Kunal Joshi
kunal1.joshi at intel.com
Wed Apr 10 06:44:25 UTC 2024
use kmstest_force_connector_debugfs instead of igt_force_and_check_bigjoiner_status
for better cleanup of i915_bigjoiner_force_enable state.
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Cc: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
Cc: Karthik B S <karthik.b.s at intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi at intel.com>
---
tests/intel/kms_big_joiner.c | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/tests/intel/kms_big_joiner.c b/tests/intel/kms_big_joiner.c
index 078f76ac1..ebeeaff9c 100644
--- a/tests/intel/kms_big_joiner.c
+++ b/tests/intel/kms_big_joiner.c
@@ -87,7 +87,7 @@ static void set_all_master_pipes_for_platform(data_t *data)
}
}
-static void toggle_force_joiner_on_all_non_big_joiner_outputs(data_t *data, bool toggle)
+static void enable_force_joiner_on_all_non_big_joiner_outputs(data_t *data)
{
bool status;
igt_output_t *output;
@@ -95,7 +95,9 @@ static void toggle_force_joiner_on_all_non_big_joiner_outputs(data_t *data, bool
for (i = 0; i < data->non_big_joiner_output_count; i++) {
output = data->non_big_joiner_output[i];
- status = igt_force_and_check_bigjoiner_status(data->drm_fd, output->name, toggle);
+ status = kmstest_force_connector_debugfs(data->drm_fd,
+ output->config.connector,
+ FORCE_JOINER, "1");
igt_assert_f(status, "Failed to toggle force joiner\n");
}
}
@@ -380,15 +382,15 @@ igt_main
igt_require_f(data.n_pipes > 1,
"Minimum 2 pipes required\n");
igt_dynamic_f("single") {
- toggle_force_joiner_on_all_non_big_joiner_outputs(&data, true);
+ enable_force_joiner_on_all_non_big_joiner_outputs(&data);
test_single_joiner(&data, data.non_big_joiner_output_count, true);
- toggle_force_joiner_on_all_non_big_joiner_outputs(&data, false);
+ igt_reset_connectors_debugfs();
}
if (data.non_big_joiner_output_count > 1) {
igt_dynamic_f("multi") {
- toggle_force_joiner_on_all_non_big_joiner_outputs(&data, true);
+ enable_force_joiner_on_all_non_big_joiner_outputs(&data);
test_multi_joiner(&data, data.non_big_joiner_output_count, true);
- toggle_force_joiner_on_all_non_big_joiner_outputs(&data, false);
+ igt_reset_connectors_debugfs();
}
}
}
@@ -402,16 +404,16 @@ igt_main
"Minimum of 2 pipes are required\n");
if (data.non_big_joiner_output_count >= 1) {
igt_dynamic_f("big_joiner_on_last_pipe") {
- toggle_force_joiner_on_all_non_big_joiner_outputs(&data, true);
+ enable_force_joiner_on_all_non_big_joiner_outputs(&data);
test_joiner_on_last_pipe(&data, true);
- toggle_force_joiner_on_all_non_big_joiner_outputs(&data, false);
+ igt_reset_connectors_debugfs();
}
}
if (data.non_big_joiner_output_count > 1) {
igt_dynamic_f("invalid_combinations") {
- toggle_force_joiner_on_all_non_big_joiner_outputs(&data, true);
+ enable_force_joiner_on_all_non_big_joiner_outputs(&data);
test_invalid_modeset_two_joiner(&data, false, true);
- toggle_force_joiner_on_all_non_big_joiner_outputs(&data, false);
+ igt_reset_connectors_debugfs();
}
}
}
@@ -419,5 +421,6 @@ igt_main
igt_fixture {
igt_display_fini(&data.display);
drm_close_driver(data.drm_fd);
+ igt_reset_connectors_debugfs();
}
}
--
2.34.1
More information about the igt-dev
mailing list