[PATCH i-g-t 4/5] tests/intel: Remove documentation collisions in i915_selftest

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Apr 10 15:37:19 UTC 2024


Hi Katarzyna,
On 2024-04-09 at 11:19:14 +0000, Katarzyna Piecielska wrote:
> Let's remove Category/Sub-category/Functionality name collisions.
> Also reorder documentation in those cases to follow pattern as in other
> tests:
> 	SUBTEST
> 	Description
> 	Category
> 	Sub-category
> 	Functionality
> 	Feature

Here one is left:

 * SUBTEST: live at display
 * Category: Selftest
 * Functionality: display sanity
 * Test category: i915
 * Sub-category: Display
---------------- ^^^^^^^
imho here should be:
 * Sub-category: Selftest subcategory

Regards,
Kamil

> 
> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
>  tests/intel/i915_selftest.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/intel/i915_selftest.c b/tests/intel/i915_selftest.c
> index edacb6250..1d03fb388 100644
> --- a/tests/intel/i915_selftest.c
> +++ b/tests/intel/i915_selftest.c
> @@ -28,10 +28,10 @@
>   * Description: Basic unit tests for i915.ko
>   *
>   * SUBTEST: live
> - * Feature: gem_core
> - * Sub-category: Selftest
>   * Category: Selftest
> + * Sub-category: Selftest subcategory
>   * Functionality: live selftest
> + * Feature: gem_core
>   *
>   * SUBTEST: live at active
>   * Category: Selftest
> @@ -312,11 +312,11 @@
>   * Sub-category: Reset
>   *
>   * SUBTEST: live at sanitycheck
> - * Category: Selftest
>   * Description: Checks the selftest infrastructure itself
> - * Functionality: selftest
> - * Test category: i915
> + * Category: Selftest
>   * Sub-category: Core
> + * Functionality: sanitycheck
> + * Test category: i915
>   *
>   * SUBTEST: live at scheduler
>   * Category: Selftest
> @@ -369,9 +369,9 @@
>   *
>   * SUBTEST: mock
>   * Category: Selftest
> - * Feature: gem_core
> - * Sub-category: Selftest
> + * Sub-category: Selftest subcategory
>   * Functionality: mock selftest
> + * Feature: gem_core
>   *
>   * SUBTEST: mock at buddy
>   * Category: Selftest
> @@ -465,11 +465,11 @@
>   * Sub-category: uapi
>   *
>   * SUBTEST: mock at sanitycheck
> - * Category: Selftest
>   * Description: Selftest for the selftest
> - * Functionality: selftest
> - * Test category: i915
> + * Category: Selftest
>   * Sub-category: Core
> + * Functionality: sanitycheck
> + * Test category: i915
>   *
>   * SUBTEST: mock at scatterlist
>   * Category: Selftest
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list