[PATCH i-g-t 04/13] tools/intel_vbt_decode: Print the block min size

Jani Nikula jani.nikula at intel.com
Thu Apr 11 12:24:18 UTC 2024


On Fri, 22 Mar 2024, Ville Syrjala <ville.syrjala at linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Print out our idea of the minimum size for each block. Can be
> helpful in determining if we're potentially decoding stuff
> that's not really present.

Feels like min size is slightly misleading, but that's how it's referred
to in code, so *shrug*

Reviewed-by: Jani Nikula <jani.nikula at intel.com>


>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  tools/intel_vbt_decode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index 1d1ba46db6e7..ead3dd6450e9 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -2672,8 +2672,8 @@ static bool dump_section(struct context *context, int section_id)
>  		}
>  	}
>  
> -	printf("BDB block %d (%d bytes) - %s%s:\n",
> -	       block->id, block->size,
> +	printf("BDB block %d (%d bytes, min %zu bytes) - %s%s:\n",
> +	       block->id, block->size, block_min_size(context, block->id),
>  	       dumper ? dumper->name : "Unknown",
>  	       dumper && !dumper->dump ? ", no decoding available" : "");

-- 
Jani Nikula, Intel


More information about the igt-dev mailing list