[i-g-t,v3,3/5] tests/intel: Remove documentation collision for Obsolete category

Kamil Konieczny kamil.konieczny at linux.intel.com
Thu Apr 11 14:03:27 UTC 2024


Hi Katarzyna,
On 2024-04-11 at 13:15:52 +0000, Katarzyna Piecielska wrote:
> Let's remove collision in Category and Feature.
> Once I am here let's order docs as in other places:
> 	SUBTEST
> 	Description
> 	Category
> 	Sub-category
> 	Funtionality
> 	Feature
> v2: s/obsolete/obsolete_test/ for 2 remaining kms tests.
> 
> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
>  tests/intel/gem_exec_params.c          | 4 ++--
>  tests/intel/gen3_mixed_blits.c         | 4 ++--
>  tests/intel/gen3_render_linear_blits.c | 4 ++--
>  tests/intel/gen3_render_mixed_blits.c  | 4 ++--
>  tests/intel/gen3_render_tiledx_blits.c | 4 ++--
>  tests/intel/gen3_render_tiledy_blits.c | 4 ++--
>  tests/intel/kms_pipe_b_c_ivb.c         | 2 +-
>  tests/intel/perf.c                     | 6 +++---
>  tests/kms_tv_load_detect.c             | 2 +-
>  9 files changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/tests/intel/gem_exec_params.c b/tests/intel/gem_exec_params.c
> index 9ce4d7653..b2f8fb247 100644
> --- a/tests/intel/gem_exec_params.c
> +++ b/tests/intel/gem_exec_params.c
> @@ -111,10 +111,10 @@
>   * SUBTEST: rsvd2-dirt
>   *
>   * SUBTEST: secure-non-master
> - * Feature: cmd_submission, obsolete
> + * Feature: cmd_submission, obsolete test
>   *
>   * SUBTEST: secure-non-root
> - * Feature: cmd_submission, obsolete
> + * Feature: cmd_submission, obsolete test
>   *
>   * SUBTEST: sol-reset-invalid
>   *
> diff --git a/tests/intel/gen3_mixed_blits.c b/tests/intel/gen3_mixed_blits.c
> index ea65579b2..55bbb5d45 100644
> --- a/tests/intel/gen3_mixed_blits.c
> +++ b/tests/intel/gen3_mixed_blits.c
> @@ -50,10 +50,10 @@
>  #include "igt.h"
>  /**
>   * TEST: gen3 mixed blits
> - * Feature: obsolete
> + * Category: Obsolete
>   * Sub-category: Obsolete_gen3
>   * Functionality: obsolete_test
> - * Category: Obsolete
> + * Feature: obsolete test
>   *
>   * SUBTEST:
>   */
> diff --git a/tests/intel/gen3_render_linear_blits.c b/tests/intel/gen3_render_linear_blits.c
> index e370c4406..43a443e0a 100644
> --- a/tests/intel/gen3_render_linear_blits.c
> +++ b/tests/intel/gen3_render_linear_blits.c
> @@ -49,10 +49,10 @@
>  #include "igt.h"
>  /**
>   * TEST: gen3 render linear blits
> - * Feature: obsolete
> + * Category: Obsolete
>   * Sub-category: Obsolete_gen3
>   * Functionality: obsolete_test
> - * Category: Obsolete
> + * Feature: obsolete test
>   *
>   * SUBTEST:
>   */
> diff --git a/tests/intel/gen3_render_mixed_blits.c b/tests/intel/gen3_render_mixed_blits.c
> index 14fae3e7b..c7336adfe 100644
> --- a/tests/intel/gen3_render_mixed_blits.c
> +++ b/tests/intel/gen3_render_mixed_blits.c
> @@ -50,10 +50,10 @@
>  #include "igt.h"
>  /**
>   * TEST: gen3 render mixed blits
> - * Feature: obsolete
> + * Category: Obsolete
>   * Sub-category: Obsolete_gen3
>   * Functionality: obsolete_test
> - * Category: Obsolete
> + * Feature: obsolete test
>   *
>   * SUBTEST:
>   */
> diff --git a/tests/intel/gen3_render_tiledx_blits.c b/tests/intel/gen3_render_tiledx_blits.c
> index a2748f272..f5818135b 100644
> --- a/tests/intel/gen3_render_tiledx_blits.c
> +++ b/tests/intel/gen3_render_tiledx_blits.c
> @@ -50,10 +50,10 @@
>  #include "igt.h"
>  /**
>   * TEST: gen3 render tiledx blits
> - * Feature: obsolete
> - * Sub-category: Obsolete_gen3
>   * Category: Obsolete
> + * Sub-category: Obsolete_gen3
>   * Functionality: obsolete_test
> + * Feature: obsolete test
>   *
>   * SUBTEST:
>   */
> diff --git a/tests/intel/gen3_render_tiledy_blits.c b/tests/intel/gen3_render_tiledy_blits.c
> index eb63aaa82..b40be62f6 100644
> --- a/tests/intel/gen3_render_tiledy_blits.c
> +++ b/tests/intel/gen3_render_tiledy_blits.c
> @@ -50,10 +50,10 @@
>  #include "igt.h"
>  /**
>   * TEST: gen3 render tiledy blits
> - * Feature: obsolete
> - * Sub-category: Obsolete_gen3
>   * Category: Obsolete
> + * Sub-category: Obsolete_gen3
>   * Functionality: obsolete_test
> + * Feature: obsolete test
>   *
>   * SUBTEST:
>   */
> diff --git a/tests/intel/kms_pipe_b_c_ivb.c b/tests/intel/kms_pipe_b_c_ivb.c
> index 73277e970..71699e792 100644
> --- a/tests/intel/kms_pipe_b_c_ivb.c
> +++ b/tests/intel/kms_pipe_b_c_ivb.c
> @@ -30,7 +30,7 @@
>   * Description: Exercise the FDI lane bifurcation code for IVB in the kernel by
>   *              setting different combinations of modes for pipes B and C.
>   * Driver requirement: i915
> - * Functionality: kms_core, obsolete
> + * Functionality: kms_core, obsolete_test
>   * Mega feature: General Display Features
>   * Test category: functionality test
>   */
> diff --git a/tests/intel/perf.c b/tests/intel/perf.c
> index 651ea9fd8..7a63a3bdd 100644
> --- a/tests/intel/perf.c
> +++ b/tests/intel/perf.c
> @@ -99,7 +99,7 @@
>   * Feature: oa perf
>   *
>   * SUBTEST: gen8-unprivileged-single-ctx-counters
> - * Feature: oa perf, obsolete
> + * Feature: oa perf, obsolete test
>   *
>   * SUBTEST: global-sseu-config
>   * Description: Verify specifying SSEU opening parameters
> @@ -155,7 +155,7 @@
>   * Description: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: per-context-mode-unprivileged
> - * Feature: oa perf, obsolete
> + * Feature: oa perf, obsolete test
>   *
>   * SUBTEST: polling
>   * Description: Test polled read with default hrtimer frequency
> @@ -180,7 +180,7 @@
>   * Description: Test the i915 perf metrics streaming interface
>   *
>   * SUBTEST: unprivileged-single-ctx-counters
> - * Feature: oa perf, obsolete
> + * Feature: oa perf, obsolete test
>   *
>   * SUBTEST: whitelisted-registers-userspace-config
>   * Description: Test the i915 perf metrics streaming interface
> diff --git a/tests/kms_tv_load_detect.c b/tests/kms_tv_load_detect.c
> index 13394f2c6..7270172a2 100644
> --- a/tests/kms_tv_load_detect.c
> +++ b/tests/kms_tv_load_detect.c
> @@ -34,7 +34,7 @@
>   * SUBTEST: load-detect
>   * Description: Check tv load detection works correctly.
>   * Driver requirement: i915, xe
> - * Functionality: obsolete
> + * Functionality: obsolete test
---------------------------- ^
This should be "obsolete_test", it can be corrected at merge.

With this fixed:

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

>   * Mega feature: General Display Features
>   * Test category: functionality test
>   */


More information about the igt-dev mailing list