[i-g-t,v3,4/5] tests/intel: Remove documentation collisions in i915_selftest
Kamil Konieczny
kamil.konieczny at linux.intel.com
Thu Apr 11 14:11:26 UTC 2024
Hi Katarzyna,
On 2024-04-11 at 13:15:53 +0000, Katarzyna Piecielska wrote:
> Let's remove Category/Sub-category/Functionality name collisions.
> Also reorder documentation in those cases to follow pattern as in other
> tests:
> SUBTEST
> Description
> Category
> Sub-category
> Functionality
> Feature
>
> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
LGTM
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
> tests/intel/i915_selftest.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/tests/intel/i915_selftest.c b/tests/intel/i915_selftest.c
> index edacb6250..a466a9009 100644
> --- a/tests/intel/i915_selftest.c
> +++ b/tests/intel/i915_selftest.c
> @@ -28,10 +28,10 @@
> * Description: Basic unit tests for i915.ko
> *
> * SUBTEST: live
> - * Feature: gem_core
> - * Sub-category: Selftest
> * Category: Selftest
> + * Sub-category: Selftest subcategory
> * Functionality: live selftest
> + * Feature: gem_core
> *
> * SUBTEST: live at active
> * Category: Selftest
> @@ -70,7 +70,7 @@
> * Category: Selftest
> * Functionality: display sanity
> * Test category: i915
> - * Sub-category: Display
> + * Sub-category: Display tests
> *
> * SUBTEST: live at dmabuf
> * Category: Selftest
> @@ -312,11 +312,11 @@
> * Sub-category: Reset
> *
> * SUBTEST: live at sanitycheck
> - * Category: Selftest
> * Description: Checks the selftest infrastructure itself
> - * Functionality: selftest
> - * Test category: i915
> + * Category: Selftest
> * Sub-category: Core
> + * Functionality: sanitycheck
> + * Test category: i915
> *
> * SUBTEST: live at scheduler
> * Category: Selftest
> @@ -369,9 +369,9 @@
> *
> * SUBTEST: mock
> * Category: Selftest
> - * Feature: gem_core
> - * Sub-category: Selftest
> + * Sub-category: Selftest subcategory
This is 'Core' above but can be corrected (or not) later, so
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> * Functionality: mock selftest
> + * Feature: gem_core
> *
> * SUBTEST: mock at buddy
> * Category: Selftest
> @@ -465,11 +465,11 @@
> * Sub-category: uapi
> *
> * SUBTEST: mock at sanitycheck
> - * Category: Selftest
> * Description: Selftest for the selftest
> - * Functionality: selftest
> - * Test category: i915
> + * Category: Selftest
> * Sub-category: Core
> + * Functionality: sanitycheck
> + * Test category: i915
> *
> * SUBTEST: mock at scatterlist
> * Category: Selftest
More information about the igt-dev
mailing list