[PATCH i-g-t] intel_reg: Stop warning if register spec is not there

Jani Nikula jani.nikula at intel.com
Thu Apr 11 14:55:30 UTC 2024


On Thu, 11 Apr 2024, Lucas De Marchi <lucas.demarchi at intel.com> wrote:
> I don't think we will be able to invest time to manually update them.

Agreed.

> I have a dream of being able to partially generate the regs/*.h file
> in xe. Maybe if we ever achieve that we can think of using the same
> source for igt.

Agreed.

> But as I said, I think we are far far away from that. What do you think
> should be done in the short/mid term?
>
> a) this patch as is
> b) keep the warning for verbosity > 0 as sugggested by others

Either as the first step is fine by me.

> c) just remove tools/registers to simplify the code. To be added back if
>     we ever figure how to autogenerate them with the same source that
>     autogenerates the kernel

I think they're still useful for deciding the contents of intel_reg
dump, for the platforms defined anyway. I wouldn't throw them away.

> d) something else?

I wouldn't object to incorporating the information in the tool at build
time. But if nobody has the time to do that, just let it be until we
have figured out a way to generate the info, if ever.

Since the decoding info is starting to be out of date, especially the
builtin stuff, maybe it should be made optional via a --decode parameter
similar to --binary, and default to off?

BR,
Jani.

-- 
Jani Nikula, Intel


More information about the igt-dev mailing list