[PATCH i-g-t] lib/igt_kmod: Fix sigaction write to uninitialized memory

[Zbigniew Kempczyński]

On Fri, Apr 12, 2024 at 09:15:43AM -0500, Lucas De Marchi wrote:
> On Fri, Apr 12, 2024 at 02:20:14PM +0200, Zbigniew Kempczyński wrote:
> > I've noticed on running kunit subtest:
> > 
> > ./xe_live_ktest --r xe_bo
> > 
> > IGT-Version: 1.28-NO-GIT (x86_64) (Linux: 6.8.0-xeint+ x86_64)
> > Using IGT_SRANDOM=1712922311 for randomisation
> > Starting subtest: xe_bo
> > Received signal SIGSEGV.
> > Stack trace:
> > #0 [fatal_sig_handler+0xda]
> > #1 [__sigaction+0x50]
> > #2 [__libc_sigaction+0x10f]
> > #3 [kunit_get_tests+0x417]
> > #4 [igt_kunit+0x35f]
> > #5 [__igt_unique____real_main41+0x44]
> > #6 [main+0x48]
> > #7 [__libc_init_first+0x90]
> > #8 [__libc_start_main+0x80]
> > #9 [_start+0x25]
> > Subtest xe_bo: CRASH (0.005s)
> > 
> > Looks this is related to sigaction() write to memory referenced
> > by uninitialized pointer located on the stack. Lets fix it.
> > 
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> 
> not idea why we are using a child process here. It seems more
> complicated than it should. But given this is indeed needed, the fix
> seems correct.

What do you mean child process here? I haven't found spawning in
the code.

--
Zbigniew

> 
> 
> Acked-by: Lucas De Marchi <lucas.demarchi at intel.com>
> 
> Lucas De Marchi