[PATCH 1/3] Define _LARGEFILE64_SOURCE for musl libc

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon Apr 22 15:36:33 UTC 2024


Hi Reagan,
On 2024-04-21 at 23:20:46 +0000, Reagan Bohan wrote:
> From: Reagan Bohan <xbjfk.github at gmail.com>

Please subscribe to igt-dev mailinglist, also add here
description of the commit.


> 

Signed-off-by is missing here.

> ---
>  lib/i915/gem_engine_topology.c       | 2 ++
>  tools/i915-perf/i915_perf_recorder.c | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
> index afb576afb..9b8fb85e3 100644
> --- a/lib/i915/gem_engine_topology.c
> +++ b/lib/i915/gem_engine_topology.c
> @@ -21,6 +21,8 @@
>   * IN THE SOFTWARE.
>   */
>  
> +#define _LARGEFILE64_SOURCE

Why only in these two files? Maybe better place whould be to
detect musl libc compilation and add it into meson define?

Regards,
Kamil

> +
>  #include <fcntl.h>
>  #include <sys/stat.h>
>  #include <sys/syscall.h>
> diff --git a/tools/i915-perf/i915_perf_recorder.c b/tools/i915-perf/i915_perf_recorder.c
> index ca4354832..5e7c233dd 100644
> --- a/tools/i915-perf/i915_perf_recorder.c
> +++ b/tools/i915-perf/i915_perf_recorder.c
> @@ -20,6 +20,8 @@
>   * SOFTWARE.
>   */
>  
> +#define _LARGEFILE64_SOURCE
> +
>  #include <assert.h>
>  #include <dirent.h>
>  #include <errno.h>
> -- 
> 2.43.2
> 


More information about the igt-dev mailing list