[PATCH 3/3] Change sys/signal.h to signal.h

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon Apr 22 15:49:47 UTC 2024


Hi Reagan,
On 2024-04-21 at 23:20:48 +0000, Reagan Bohan wrote:
> From: Reagan Bohan <xbjfk.github at gmail.com>
> 
> Not only is sys/signal.h non standard, it also:
> a) emits a warning on musl libc
> b) made the code inconsistent, as some files used signal.h and some
> sys/signal.h

Missing s-o-b.

Regards,
Kamil

> ---
>  tests/intel/gem_exec_await.c           | 2 +-
>  tests/intel/gem_exec_balancer.c        | 2 +-
>  tests/intel/gem_exec_fence.c           | 2 +-
>  tests/intel/gem_exec_latency.c         | 2 +-
>  tests/intel/gem_unref_active_buffers.c | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/intel/gem_exec_await.c b/tests/intel/gem_exec_await.c
> index fcbca1547..cc976f09d 100644
> --- a/tests/intel/gem_exec_await.c
> +++ b/tests/intel/gem_exec_await.c
> @@ -22,8 +22,8 @@
>   *
>   */
>  
> +#include <signal.h>
>  #include <sys/ioctl.h>
> -#include <sys/signal.h>
>  
>  #include "drmtest.h"
>  #include "i915/gem.h"
> diff --git a/tests/intel/gem_exec_balancer.c b/tests/intel/gem_exec_balancer.c
> index 7504f3737..83cc7eea4 100644
> --- a/tests/intel/gem_exec_balancer.c
> +++ b/tests/intel/gem_exec_balancer.c
> @@ -23,8 +23,8 @@
>  
>  #include <fcntl.h>
>  #include <sched.h>
> +#include <signal.h>
>  #include <sys/ioctl.h>
> -#include <sys/signal.h>
>  #include <poll.h>
>  
>  #include "dmabuf_sync_file.h"
> diff --git a/tests/intel/gem_exec_fence.c b/tests/intel/gem_exec_fence.c
> index 28bad83f6..deff18abc 100644
> --- a/tests/intel/gem_exec_fence.c
> +++ b/tests/intel/gem_exec_fence.c
> @@ -23,8 +23,8 @@
>  
>  #include <poll.h>
>  #include <string.h>
> +#include <signal.h>
>  #include <sys/ioctl.h>
> -#include <sys/signal.h>
>  #include "i915/gem.h"
>  #include "i915/gem_create.h"
>  #include "igt.h"
> diff --git a/tests/intel/gem_exec_latency.c b/tests/intel/gem_exec_latency.c
> index b9d086afc..b802c2f31 100644
> --- a/tests/intel/gem_exec_latency.c
> +++ b/tests/intel/gem_exec_latency.c
> @@ -30,10 +30,10 @@
>  #include <fcntl.h>
>  #include <inttypes.h>
>  #include <errno.h>
> +#include <signal.h>
>  #include <sys/stat.h>
>  #include <sys/ioctl.h>
>  #include <sys/time.h>
> -#include <sys/signal.h>
>  #include <time.h>
>  #include <sched.h>
>  
> diff --git a/tests/intel/gem_unref_active_buffers.c b/tests/intel/gem_unref_active_buffers.c
> index f8138c7ac..47f792738 100644
> --- a/tests/intel/gem_unref_active_buffers.c
> +++ b/tests/intel/gem_unref_active_buffers.c
> @@ -34,8 +34,8 @@
>  #include <errno.h>
>  #include <fcntl.h>
>  #include <inttypes.h>
> +#include <signal.h>
>  #include <sys/ioctl.h>
> -#include <sys/signal.h>
>  #include <sys/time.h>
>  
>  #include "igt.h"
> -- 
> 2.43.2
> 


More information about the igt-dev mailing list