[PATCH] intel_reg: Move decoding behind an option

Lucas De Marchi lucas.demarchi at intel.com
Wed Apr 24 00:04:27 UTC 2024


On Tue, Apr 23, 2024 at 09:48:28PM GMT, Kamil Konieczny wrote:
>Hi Lucas,
>On 2024-04-16 at 10:42:07 -0500, Lucas De Marchi wrote:
>
>small nit, use prefix "tools/" in subject, so instead of
>
>[PATCH] intel_reg: Move decoding behind an option
>
>better:
>[PATCH i-g-t] tools/intel_reg: Move decoding behind an option

I read this too late. Just submitted another patch series touching gputop
without having the dir prefix... `git log -- tools/gputop.c` seems to
agree about not using the tools/ dir although the same for intel_reg.c
it seems we are not really consistent.

As for --subject-prefix: it used to be important when we shared the
same mailing list with i915. This is long gone and there isn't much reason
to keep it anymore (unless when cross posting to other mailing lists).

>
>with that
>Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

well... It seems I had missed Jani's reply... still a few things to fix.
I will send a v2 later this week. Thanks.

Lucas De Marchi


More information about the igt-dev mailing list