[PATCH i-g-t v2 54/66] tests/xe_eudebug_online: Add support for dynamic debugger sysfs toggle

Piatkowski, Dominik Karol dominik.karol.piatkowski at intel.com
Mon Aug 5 06:30:57 UTC 2024


Reviewed-by: Dominik Karol Piątkowski <dominik.karol.piatkowski at intel.com>

> -----Original Message-----
> From: Manszewski, Christoph <christoph.manszewski at intel.com>
> Sent: Tuesday, July 30, 2024 1:45 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Kempczynski, Zbigniew <zbigniew.kempczynski at intel.com>; Kamil
> Konieczny <kamil.konieczny at linux.intel.com>; Grzegorzek, Dominik
> <dominik.grzegorzek at intel.com>; Patelczyk, Maciej
> <maciej.patelczyk at intel.com>; Piatkowski, Dominik Karol
> <dominik.karol.piatkowski at intel.com>; Sikora, Pawel
> <pawel.sikora at intel.com>; Hajda, Andrzej <andrzej.hajda at intel.com>;
> Kolanupaka Naveena <kolanupaka.naveena at intel.com>; Kuoppala, Mika
> <mika.kuoppala at intel.com>; Mun, Gwan-gyeong <gwan-
> gyeong.mun at intel.com>
> Subject: [PATCH i-g-t v2 54/66] tests/xe_eudebug_online: Add support for
> dynamic debugger sysfs toggle
> 
> From now on the debugger is disabled by default so it is required to enable the
> debugger before using it. This change addresses that fact by calling necessary
> library functions within test fixtures.
> 
> Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>
> Signed-off-by: Christoph Manszewski <christoph.manszewski at intel.com>
> Cc: Dominik Grzegorzek <dominik.grzegorzek at intel.com>
> ---
>  tests/intel/xe_eudebug_online.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
> index 5bb165fef..12edd0eb5 100644
> --- a/tests/intel/xe_eudebug_online.c
> +++ b/tests/intel/xe_eudebug_online.c
> @@ -1023,12 +1023,14 @@ static struct drm_xe_engine_class_instance
> *pick_compute(int fd, int gt)  igt_main  {
>  	struct drm_xe_engine_class_instance *hwe;
> +	bool was_enabled;
>  	int fd;
> 
>  	igt_fixture {
>  		fd = drm_open_driver(DRIVER_XE);
>  		intel_allocator_multiprocess_start();
>  		igt_srandom();
> +		was_enabled = xe_eudebug_enable(fd, true);
>  	}
> 
>  	test_gt_render_or_compute("basic-breakpoint", fd, hwe) @@ -
> 1050,6 +1052,8 @@ igt_main
>  		test_interrupt_all(fd, hwe, SHADER_LOOP |
> TRIGGER_RESUME_SET_BP);
> 
>  	igt_fixture {
> +		xe_eudebug_enable(fd, was_enabled);
> +
>  		intel_allocator_multiprocess_stop();
>  		drm_close_driver(fd);
>  	}
> --
> 2.34.1



More information about the igt-dev mailing list