[PATCH i-g-t v4 2/4] tests/intel/kms_pm_dc: Update test duration to 4 seconds
Kandpal, Suraj
suraj.kandpal at intel.com
Tue Aug 13 09:23:56 UTC 2024
> -----Original Message-----
> From: Naladala, Ramanaidu <ramanaidu.naladala at intel.com>
> Sent: Monday, August 12, 2024 1:34 AM
> To: igt-dev at lists.freedesktop.org
> Cc: Kandpal, Suraj <suraj.kandpal at intel.com>; B, Jeevan <jeevan.b at intel.com>;
> Naladala, Ramanaidu <ramanaidu.naladala at intel.com>
> Subject: [PATCH i-g-t v4 2/4] tests/intel/kms_pm_dc: Update test duration to 4
> seconds
>
> Certain features can prevent timely entry into the C10 state, causing inconsistent
> results. So increase test time to get accurate results.
>
> v2: Split the patch into two. (Kamil)
> v3: Declare variable in new line. (Suraj)
>
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
> ---
> tests/intel/kms_pm_dc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c index
> 367bf4303..565c3d48d 100644
> --- a/tests/intel/kms_pm_dc.c
> +++ b/tests/intel/kms_pm_dc.c
> @@ -591,7 +591,8 @@ static unsigned int read_pkgc_counter(int
> debugfs_root_fd) static void test_deep_pkgc_state(data_t *data) {
> unsigned int pre_val = 0, cur_val = 0;
> - time_t start = time(NULL), duration = 2, delay;
> + time_t start = time(NULL);
> + time_t duration = 4, delay;
Why is the duration 4 or how did you come to this number explain , if in ms don't we have a define for that use that its
not good to use magic number.
Regards,
Suraj Kandpal
> enum pipe pipe;
> bool pkgc_flag = false;
> bool flip = true;
> --
> 2.43.0
More information about the igt-dev
mailing list