[PATCH v5 09/37] tests/kms_properties: Add colorop properties test
Harry Wentland
harry.wentland at amd.com
Mon Aug 19 20:57:55 UTC 2024
We've introduced the concept of a new DRM core object, the
drm_colorop, to represent a color operation as part of a
color pipeline.
Add new tests to kms_properties to test the properties of
a drm_colorop object.
v3:
- Update test to work without new libdrm definitions for
colorop objects
- Test colorop properties with both atomic and legacy
code paths
Signed-off-by: Harry Wentland <harry.wentland at amd.com>
---
tests/kms_properties.c | 69 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/tests/kms_properties.c b/tests/kms_properties.c
index a93c93cccf64..75252b3c9dbe 100644
--- a/tests/kms_properties.c
+++ b/tests/kms_properties.c
@@ -49,6 +49,7 @@
* @crtc: CRTC
* @plane: Plane
* @invalid: Invalid (connector/crtc/plane)
+ * @colorop: Colorop
*
* arg[2]:
*
@@ -221,6 +222,39 @@ static void test_properties(int fd, uint32_t type, uint32_t id, bool atomic)
}
}
+static void run_colorop_property_tests(igt_display_t *display, enum pipe pipe, igt_output_t *output, bool atomic)
+{
+ struct igt_fb fb;
+ igt_plane_t *plane;
+ igt_colorop_t *colorop;
+ int i;
+ int colorop_id = 0;
+
+ prepare_pipe(display, pipe, output, &fb);
+
+ for_each_plane_on_pipe(display, pipe, plane) {
+ igt_info("Testing colorop properties on plane %s.#%d-%s (output: %s)\n",
+ kmstest_pipe_name(pipe), plane->index, kmstest_plane_type_name(plane->type), output->name);
+
+ /* iterate over all color pipelines on plane */
+ for (i = 0; i < plane->num_color_pipelines; ++i) {
+ /* iterate over all colorops in pipeline*/
+ colorop = plane->color_pipelines[i];
+ while (colorop) {
+ igt_info("Testing colorop properties on %s.#%d.#%d-%s (output: %s)\n",
+ kmstest_pipe_name(pipe), plane->index, colorop->id, kmstest_plane_type_name(plane->type), output->name);
+ test_properties(display->drm_fd, DRM_MODE_OBJECT_COLOROP, colorop->id, atomic);
+
+ colorop_id = igt_colorop_get_prop(display, colorop,
+ IGT_COLOROP_NEXT);
+ colorop = igt_find_colorop(display, colorop_id);
+ }
+ }
+ }
+
+ cleanup_pipe(display, pipe, output, &fb);
+}
+
static void run_plane_property_tests(igt_display_t *display, enum pipe pipe, igt_output_t *output, bool atomic)
{
struct igt_fb fb;
@@ -266,6 +300,37 @@ static void run_connector_property_tests(igt_display_t *display, enum pipe pipe,
cleanup_pipe(display, pipe, output, &fb);
}
+static void colorop_properties(igt_display_t *display, bool atomic)
+{
+ bool found_any = false, found;
+ igt_output_t *output;
+ enum pipe pipe;
+
+ /* colorops are only available with atomic */
+ igt_skip_on(!display->is_atomic);
+
+ for_each_pipe(display, pipe) {
+ found = false;
+
+ for_each_valid_output_on_pipe(display, pipe, output) {
+ igt_display_reset(display);
+
+ igt_output_set_pipe(output, pipe);
+ if (!intel_pipe_output_combo_valid(display))
+ continue;
+
+ found_any = found = true;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe),
+ igt_output_name(output)) {
+ run_colorop_property_tests(display, pipe, output, atomic);
+ }
+ }
+ }
+
+ igt_skip_on(!found_any);
+}
+
static void plane_properties(igt_display_t *display, bool atomic)
{
igt_output_t *output;
@@ -779,6 +844,10 @@ igt_main
"Tests connector properties with legacy commit" },
{ "connector-properties-atomic", connector_properties, true,
"Tests connector properties with atomic commit" },
+ { "colorop-properties-legacy", colorop_properties, false,
+ "Tests colorop properties with legacy commit" },
+ { "colorop-properties-atomic", colorop_properties, true,
+ "Tests colorop properties with atomic commit" },
};
igt_fixture {
--
2.46.0
More information about the igt-dev
mailing list