[PATCH] tests/dumb_buffer: Fix invalid bpp subtest

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue Aug 20 12:49:26 UTC 2024


Hi Rob,
On 2024-08-19 at 13:26:42 -0700, Rob Clark wrote:
> From: Rob Clark <robdclark at chromium.org>
> 
> Only zero is actually considered an invalid value by the kernel.
> 
> Signed-off-by: Rob Clark <robdclark at chromium.org>

Thank you for fixing this, driver later can add more checks
but at drm layer you are right, so

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tests/dumb_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/dumb_buffer.c b/tests/dumb_buffer.c
> index 1d4bf296c53e..e1c18c70b09b 100644
> --- a/tests/dumb_buffer.c
> +++ b/tests/dumb_buffer.c
> @@ -143,7 +143,7 @@ static void invalid_dimensions_test(int fd)
>  	memset(&create, 0, sizeof(create));
>  	create.width = 4032;
>  	create.height = 2016;
> -	create.bpp = 24;
> +	create.bpp = 0;
>  	igt_assert_eq(__dumb_create(fd, &create), -EINVAL);
>  
>  	create.bpp = 32;
> -- 
> 2.46.0
> 


More information about the igt-dev mailing list