[i-g-t 3/4] tests/kms_vblank: Add more logs to skips

[Samala, Pranay]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Tuesday, August 13, 2024 11:09 AM
> To: igt-dev at lists.freedesktop.org
> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> Subject: [i-g-t 3/4] tests/kms_vblank: Add more logs to skips
> 
> Debugging would be easier if we had logs available for test failures and skips. This
> patch adds print statements at crucial points to provide better insights.

Apart from the below changes the changes LGTM.

Reviewed-by: Pranay Samala <pranay.samala at intel.com> 
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>  tests/kms_vblank.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c index
> 696bc0b71..c53741b62 100644
> --- a/tests/kms_vblank.c
> +++ b/tests/kms_vblank.c
> @@ -520,8 +520,10 @@ static void run_subtests(data_t *data)
>  						continue;
> 
>  					if (!all_pipes && data->pipe !=
> active_pipes[0] &&
> -					    data->pipe !=
> active_pipes[last_pipe])
> +					    data->pipe !=
> active_pipes[last_pipe]) {
> +						igt_info("Skipping pipe %s\n",
> kmstest_pipe_name(data->pipe));

It exceeds 100-character limitation in a line. Otherwise, the changes look good to me
>  						continue;
> +					}
> 
>  					igt_dynamic_f("pipe-%s-%s",
> kmstest_pipe_name(data->pipe), data->output->name) {
>  						data->flags = m->flags |
> NOHANG;
> @@ -544,8 +546,10 @@ static void run_subtests(data_t *data)
>  						continue;
> 
>  					if (!all_pipes && data->pipe !=
> active_pipes[0] &&
> -					    data->pipe !=
> active_pipes[last_pipe])
> +					    data->pipe !=
> active_pipes[last_pipe]) {
> +						igt_info("Skipping pipe %s\n",
> kmstest_pipe_name(data->pipe));

Same as above comments.
>  						continue;
> +					}
> 
>  					igt_dynamic_f("pipe-%s-%s",
> kmstest_pipe_name(data->pipe), data->output->name) {
>  						data->flags = m->flags;
> @@ -656,8 +660,10 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
>  				continue;
> 
>  			if (!all_pipes && data.pipe != active_pipes[0] &&
> -					  data.pipe != active_pipes[last_pipe])
> +					  data.pipe != active_pipes[last_pipe]) {
> +				igt_info("Skipping pipe %s\n",
> kmstest_pipe_name(data.pipe));
>  				continue;
> +			}
> 
>  			igt_dynamic_f("pipe-%s-%s",
> kmstest_pipe_name(data.pipe), data.output->name)
>  				crtc_id_subtest(&data, fd);
> --
> 2.43.2