[PATCH i-g-t 07/37] lib/rendercopy: Don't skip clearcolor on flat CCS

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Tue Aug 27 15:16:48 UTC 2024


Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On 3.7.2024 2.27, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> We always need to tell the hardware about the clear
> color buffer, otherwise if we sample from a fast cleared
> buffer we get complete garbage.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>   lib/rendercopy_gen9.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
> index f0757a8e6b78..57b64dad1b1d 100644
> --- a/lib/rendercopy_gen9.c
> +++ b/lib/rendercopy_gen9.c
> @@ -249,7 +249,7 @@ gen9_bind_buf(struct intel_bb *ibb, const struct intel_buf *buf, int is_dst,
>   			ss->ss11.aux_base_addr_hi = (address + buf->ccs[0].offset) >> 32;
>   		}
>   
> -		if (fast_clear || (buf->cc.offset && !HAS_FLATCCS(ibb->devid))) {
> +		if (buf->cc.offset) {
>   			igt_assert(buf->compression == I915_COMPRESSION_RENDER);
>   
>   			ss->ss10.clearvalue_addr_enable = 1;



More information about the igt-dev mailing list