[PATCH i-g-t 33/37] tests/kms_ccs: Correctly check clear color for 10bpc formats

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Tue Aug 27 17:48:35 UTC 2024


Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On 3.7.2024 2.28, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> The hardware generated clear color will be in the native
> pixel format. Generate the reference correctly for 10bpc
> formats.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>   tests/intel/kms_ccs.c | 22 +++++++++++++++++-----
>   1 file changed, 17 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/intel/kms_ccs.c b/tests/intel/kms_ccs.c
> index 30b61f132834..4c1c78ee4e58 100644
> --- a/tests/intel/kms_ccs.c
> +++ b/tests/intel/kms_ccs.c
> @@ -321,7 +321,7 @@ static void check_ccs_cc_plane(int drm_fd, igt_fb_t *fb, int plane, const float
>   		uint32_t d;
>   	} *cc_p;
>   	void *map;
> -	uint32_t native_color;
> +	uint32_t native_color = 0;
>   
>   	if (is_i915_device(drm_fd)) {
>   		gem_set_domain(drm_fd, fb->gem_handle, I915_GEM_DOMAIN_CPU, 0);
> @@ -336,10 +336,22 @@ static void check_ccs_cc_plane(int drm_fd, igt_fb_t *fb, int plane, const float
>   		   cc_color[2] == cc_p[2].f &&
>   		   cc_color[3] == cc_p[3].f);
>   
> -	native_color = (uint8_t)(cc_color[3] * 0xff) << 24 |
> -		       (uint8_t)(cc_color[0] * 0xff) << 16 |
> -		       (uint8_t)(cc_color[1] * 0xff) << 8 |
> -		       (uint8_t)(cc_color[2] * 0xff);
> +	switch (fb->drm_format) {
> +	case DRM_FORMAT_XRGB8888:
> +		native_color = (uint32_t)(cc_color[3] * 0xff) << 24 |
> +			(uint32_t)(cc_color[0] * 0xff) << 16 |
> +			(uint32_t)(cc_color[1] * 0xff) << 8 |
> +			(uint32_t)(cc_color[2] * 0xff);
> +		break;
> +	case DRM_FORMAT_XRGB2101010:
> +		native_color = (uint32_t)(cc_color[3] * 0x3) << 30 |
> +			(uint32_t)(cc_color[0] * 0x3ff) << 20 |
> +			(uint32_t)(cc_color[1] * 0x3ff) << 10 |
> +			(uint32_t)(cc_color[2] * 0x3ff);
> +		break;
> +	default:
> +		break;
> +	}
>   
>   	igt_assert(native_color == cc_p[4].d);
>   



More information about the igt-dev mailing list