[PATCH i-g-t v5 4/4] tests/intel/kms_pm_dc: Add polling for deep-pkgc

[Kandpal, Suraj]

> -----Original Message-----
> From: Naladala, Ramanaidu <ramanaidu.naladala at intel.com>
> Sent: Tuesday, August 27, 2024 6:10 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Kandpal, Suraj <suraj.kandpal at intel.com>; B, Jeevan
> <jeevan.b at intel.com>; Naladala, Ramanaidu
> <ramanaidu.naladala at intel.com>
> Subject: [PATCH i-g-t v5 4/4] tests/intel/kms_pm_dc: Add polling for deep-pkgc
> 
> It should be enhance the test_deep_pkgc_state function to include the
> following changes:

The above statement makes no sense 
Reword it to Include the following changes to enahance test_deep_pkgc_state():

Rest LGTM,

Reviewed-by: Suraj Kandpal <suraj.kandpal at intel.com>

> - Add an interval variable to control the delay between checks.
> - Add a wait for vblank to sync the frame time before reading
>   the package C-state counter.
> - Introduce a half-frame delay to ensure the flip occurs when
>   the frame is active.
> - Modify the loop to use igt_wait for better handling of the
>   package C-state counter read.
> - Remove redundant usleep call to streamline the delay handling.
> 
> v2: Address and correct review comments (Suraj, Jeevan)
> v3: Update commit subject/message.  (Kamil)
> v4: Update commit subject/message and added comments. (Suraj)
> v5: Update commit subject/message. (Suraj)
> 
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
> ---
>  tests/intel/kms_pm_dc.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c index
> a69876fc7..b378cacbc 100644
> --- a/tests/intel/kms_pm_dc.c
> +++ b/tests/intel/kms_pm_dc.c
> @@ -641,22 +641,25 @@ static void test_deep_pkgc_state(data_t *data)
>  	setup_videoplayback(data);
> 
>  	primary = igt_output_get_plane_type(data->output,
> DRM_PLANE_TYPE_PRIMARY);
> -	pre_val = read_pkgc_counter(data->debugfs_root_fd);
> -
>  	igt_plane_set_fb(primary, &data->fb_rgb);
>  	igt_display_commit(&data->display);
> +	/* Wait for the vblank to sync the frame time */
> +	igt_wait_for_vblank_count(data->drm_fd, data-
> >display.pipes[pipe].crtc_offset, 1);
> +	pre_val = read_pkgc_counter(data->debugfs_root_fd);
> +	/* Add a half-frame delay to ensure the flip occurs when the frame is
> active. */
> +	usleep(delay * 0.5);
> 
>  	while (time(NULL) - start < duration) {
>  		flip = !flip;
>  		igt_plane_set_fb(primary, flip ? &data->fb_rgb : &data-
> >fb_rgr);
>  		igt_display_commit(&data->display);
> 
> -		cur_val = read_pkgc_counter(data->debugfs_root_fd);
> +		igt_wait((cur_val = read_pkgc_counter(data-
> >debugfs_root_fd)) > pre_val,
> +						      (delay * 2), (5 * MSEC));
>  		if (cur_val > pre_val) {
>  			pkgc_flag = true;
>  			break;
>  		}
> -		usleep(delay);
>  	}
> 
>  	cleanup_dc3co_fbs(data);
> --
> 2.43.0