[PATCH i-g-t 1/2] tests/intel/dsc: Convert debug msg to info msg

Samala, Pranay pranay.samala at intel.com
Mon Dec 2 11:18:38 UTC 2024



> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Swati
> Sharma
> Sent: Monday, December 2, 2024 2:21 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Sharma, Swati2 <swati2.sharma at intel.com>
> Subject: [PATCH i-g-t 1/2] tests/intel/dsc: Convert debug msg to info msg
> 
> Convert `igt_debug` to `igt_info` to provide more context when skipping outputs
> that doesn't fulfil dsc constraints.
> 
> Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
> ---
>  tests/intel/kms_dsc_helper.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/intel/kms_dsc_helper.c b/tests/intel/kms_dsc_helper.c index
> 0de09b8e9..cea4304e4 100644
> --- a/tests/intel/kms_dsc_helper.c
> +++ b/tests/intel/kms_dsc_helper.c
> @@ -69,14 +69,14 @@ bool is_dsc_supported_by_source(int drmfd)  bool
> is_dsc_supported_by_sink(int drmfd, igt_output_t *output)  {
>  	if (!igt_is_dsc_supported_by_sink(drmfd, output->name)) {
> -		igt_debug("DSC not supported on connector %s\n",
> +		igt_info("DSC not supported on connector %s\n",
>  			  output->name);

Alignment should match open parenthesis.
>  		return false;
>  	}
> 
>  	if (!output_is_internal_panel(output) &&
>  	    !igt_is_fec_supported(drmfd, output->name)) {
> -		igt_debug("DSC cannot be enabled without FEC on %s\n",
> +		igt_info("DSC cannot be enabled without FEC on %s\n",
>  			  output->name);

Same goes here.
>  		return false;
>  	}
> @@ -91,7 +91,7 @@ bool check_gen11_dp_constraint(int drmfd, igt_output_t
> *output, enum pipe pipe)
> 
>  	if ((connector->connector_type ==
> DRM_MODE_CONNECTOR_DisplayPort) &&
>  	    (pipe == PIPE_A) && IS_GEN11(devid)) {
> -		igt_debug("DSC not supported on pipe A on external DP in gen11
> platforms\n");
> +		igt_info("DSC not supported on pipe %s on %s in gen11
> platforms\n",
> +kmstest_pipe_name(pipe), output->name);

line length is 123 columns, exceeding 100 columns.
>  		return false;
>  	}
> 
> @@ -126,7 +126,7 @@ void force_dsc_output_format(int drmfd, igt_output_t
> *output,  static bool is_dsc_output_format_supported_by_source(int disp_ver,
> enum dsc_output_format output_format)  {
>  	if (disp_ver < 14 && output_format == DSC_FORMAT_YCBCR420) {
> -		igt_debug("Output format DSC YCBCR420 not supported on D13
> and older platforms\n");
> +		igt_info("Output format DSC YCBCR420 not supported on D13
> and older
> +platforms\n");
>  		return false;
>  	}
> 
> @@ -140,7 +140,7 @@ bool is_dsc_output_format_supported(int drmfd, int
> disp_ver, igt_output_t *outpu
>  		return false;
> 
>  	if (!igt_is_dsc_output_format_supported_by_sink(drmfd, output->name,
> output_format)) {
> -		igt_debug("DSC %s output format not supported on connector
> %s\n",
> +		igt_info("DSC %s output format not supported on connector
> %s\n",
>  			  kmstest_dsc_output_format_str(output_format),

Alignment should match open parenthesis.

Regards,
Pranay Samala
> output->name);
>  		return false;
>  	}
> @@ -182,7 +182,7 @@ void restore_force_dsc_fractional_bpp_en(void)
>  static bool is_dsc_fractional_bpp_supported_by_source(int disp_ver)  {
>  	if (disp_ver < 14) {
> -		igt_debug("DSC fractional bpp not supported on D13 and older
> platforms\n");
> +		igt_info("DSC fractional bpp not supported on D13 and older
> +platforms\n");
>  		return false;
>  	}
> 
> @@ -195,7 +195,7 @@ bool is_dsc_fractional_bpp_supported(int disp_ver, int
> drmfd, igt_output_t *outp
>  		return false;
> 
>  	if (!igt_is_dsc_fractional_bpp_supported_by_sink(drmfd, output->name))
> {
> -		igt_debug("DSC fractional bpp not supported on connector
> %s\n", output->name);
> +		igt_info("DSC fractional bpp not supported on connector %s\n",
> +output->name);
>  		return false;
>  	}
> 
> --
> 2.25.1



More information about the igt-dev mailing list