[PATCH i-g-t v1 1/2] tests/kms_scaling_modes: Add informative messages for skipped scaling mode tests

[Samala, Pranay]

Hi Ramanaidu,

> -----Original Message-----
> From: Naladala, Ramanaidu <ramanaidu.naladala at intel.com>
> Sent: Thursday, December 5, 2024 5:55 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Samala, Pranay <pranay.samala at intel.com>; Naladala, Ramanaidu
> <ramanaidu.naladala at intel.com>
> Subject: [PATCH i-g-t v1 1/2] tests/kms_scaling_modes: Add informative
> messages for skipped scaling mode tests
> 
> Add `igt_info` messages to provide more context when skipping outputs that do
> not support scaling mode. Include `igt_info` messages to indicate when invalid
> pipe/output combinations are skipped.
> 
> V1: Fix alignment issues. (Pranay)
> 
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
> ---
>  tests/kms_scaling_modes.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_scaling_modes.c b/tests/kms_scaling_modes.c index
> 5fd34c4b2..e8aeb7409 100644
> --- a/tests/kms_scaling_modes.c
> +++ b/tests/kms_scaling_modes.c
> @@ -117,8 +117,11 @@ static void test_scaling_mode(data_t *data, uint32_t
> flags)
>  	for_each_pipe_with_valid_output(display, pipe, output) {
>  		igt_display_reset(display);
> 
> -		if (!has_scaling_mode(output))
> +		if (!has_scaling_mode(output)) {
> +			igt_info("Output %s does not support scaling mode.\n",
> +				igt_output_name(output));

Alignment should match open parenthesis
i of igt should come below "

With this fixed, code LGTM.
Reviewed-by: Pranay Samala <pranay.samala at intel.com>
>  			continue;
> +		}
> 
>  		igt_output_set_pipe(output, pipe);
>  		if (!intel_pipe_output_combo_valid(display))
> --
> 2.43.0