[PATCH i-g-t v4 6/8] XE3: tests/kms_cursor_legacy: flip_vs_cursor_busy_crc was requiring any driver but used intel x-tile

Matt Roper matthew.d.roper at intel.com
Sat Dec 7 00:10:03 UTC 2024


On Fri, Dec 06, 2024 at 01:27:46PM -0800, Clint Taylor wrote:
> From: "Heikkila, Juha-pekka" <juha-pekka.heikkila at intel.com>
> 
> switch flip_vs_cursor_busy_crc to use linear framebuffer instead of x-tile

You should probably elaborate on why here (i.e., not all platforms
support X-tiled framebuffers anymore).

> 
> Signed-off-by: Heikkila, Juha-pekka <juha-pekka.heikkila at intel.com>

Another case where the name format needs to be fixed.


Matt

> Signed-off-by: Clint Taylor <Clinton.A.Taylor at intel.com>
> ---
>  tests/kms_cursor_legacy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index 4e2cfde17..1f082df2d 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -1679,7 +1679,7 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
>  	set_fb_on_crtc(display, pipe, output, &fb_info[0]);
>  	plane_primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
>  	igt_create_color_pattern_fb(display->drm_fd, fb_info[0].width, fb_info[0].height,
> -				    DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED, .1, .1, .1, &fb_info[1]);
> +				    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, .1, .1, .1, &fb_info[1]);
>  
>  	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>  			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
> -- 
> 2.25.1
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation


More information about the igt-dev mailing list