[PATCH] tests/kms_async_flips: Only check joiner mode on intel device

Reddy Guddati, Santhosh santhosh.reddy.guddati at intel.com
Wed Dec 11 01:56:00 UTC 2024


Hi George Zhang,

Changes LGTM.

On 11-12-2024 04:09, george.zhang at amd.com wrote:
> From: George Zhang <george.zhang at amd.com>
> 
> The joiner mode check causes the kms_async_flip tests to fail on
> non-intel devices. Added a guard to only check the joiner mode if
> running on intel device.
> 
> v2: Moved guard to within is_joiner_mode function
> 
> Signed-off-by: George Zhang <george.zhang at amd.com>
Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
> ---
>   lib/igt_kms.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 43ca2d4c2..3d061abc5 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -6467,6 +6467,9 @@ bool is_joiner_mode(int drm_fd, igt_output_t *output)
>   	int max_dotclock;
>   	drmModeModeInfo mode;
>   
> +        if (!is_intel_device(drm_fd))
> +                return false;
> +
>   	max_dotclock = igt_get_max_dotclock(drm_fd);
>   	is_joiner = bigjoiner_mode_found(drm_fd,
>   					 output->config.connector,



More information about the igt-dev mailing list