[PATCH] tests/intel/gem_exec_balancer: Decrease required load in `full` test

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue Dec 17 19:07:11 UTC 2024


Hi Andi,
On 2024-12-17 at 19:08:16 +0100, Andi Shyti wrote:
> Hi,
> 
> this patch is wrongly formatted:
> 
>  - where is the versioning? (git format patch -v <N>). I think
>    this is v4.
>  - where is the changelog? (please after the '---' section).
> 
> Please don't overlook at them next time.
> 
> On Tue, Dec 17, 2024 at 05:23:02PM +0100, Kamil Konieczny wrote:
> > Hi Sebastian,
> > On 2024-12-17 at 15:06:41 +0000, Sebastian Brzezinka wrote:
> > > Adjust the minimal load in the `full` test. It's a minor tolerance
> > > issue expected 90% got 86.6%.
> > > 
> > > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13003
> > 
> > Remove empty line, with this
> 
> Can you fix it before merging to avoid another resend?

Yes I could do it at merge time,

Regards,
Kamil

Btw such performace measuring is prone to some random noise,
when something on DUT will hog system.

Regards,
Kamil

> 
> In any case:
> 
> Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>
> 
> Thanks,
> Andi
> 
> > Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> > 
> > > 
> > > Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka at intel.com>
> > > ---
> > >  tests/intel/gem_exec_balancer.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/tests/intel/gem_exec_balancer.c b/tests/intel/gem_exec_balancer.c
> > > index c3f0c938b..46ea19a2a 100644
> > > --- a/tests/intel/gem_exec_balancer.c
> > > +++ b/tests/intel/gem_exec_balancer.c
> > > @@ -1815,7 +1815,7 @@ static void full(int i915, unsigned int flags)
> > >  
> > >  		free(ci);
> > >  
> > > -		igt_assert_f(load > 0.90,
> > > +		igt_assert_f(load > 0.85,
> > >  			     "minimum load for %d x class:%d was found to be only %.1f%% busy\n",
> > >  			     count, class, load*100);
> > >  		gem_quiescent_gpu(i915);
> > > -- 
> > > 2.34.1
> > > 


More information about the igt-dev mailing list