[PATCH] lib/core: Let ftrace know when the test started
Kamil Konieczny
kamil.konieczny at linux.intel.com
Wed Dec 18 19:13:40 UTC 2024
Hi Dixit,,
On 2024-12-17 at 15:19:59 -0800, Dixit, Ashutosh wrote:
> On Tue, 17 Dec 2024 10:39:10 -0800, Umesh Nerlige Ramappa wrote:
> >
> > It's useful to know the start and end of the test in ftrace to be able
> > to debug some issues. Not sure where to add igt_trace for end, so
> > posting this patch to get some comments.
>
> Isn't it this (at least looking at dmesg):
>
> __noreturn static void exit_subtest(const char *result)
> {
> ...
> igt_kmsg(KMSG_INFO "%s: finished subtest %s, %s\n",
> command_str, *subtest_name, result);
I also think it is already printed in logs.
Umesh if you find out cases where it is not please drop a link
to CI log(s) to look into.
Now that I look at it again the only diff is a place when it is
printed, this one is after (dynamic) subtest ends but I still
think it is also printed in dmesg before a dynamic subtest starts.
For example look into this log:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12333/shard-snb5/igt@kms_flip@flip-vs-fences@a-vga1.html
there is:
<7> [377.462024] i915 0000:00:02.0: [drm:drm_helper_probe_single_connector_modes [drm_kms_helper]] [CONNECTOR:75:DP-1] disconnected
<6> [377.463784] [IGT] kms_flip: starting subtest flip-vs-fences
<6> [377.465812] [IGT] kms_flip: starting dynamic subtest A-VGA1
Regards,
Kamil
More information about the igt-dev
mailing list