[PATCH i-g-t v5 5/7] tests/intel/kms_draw_crc: fix x-tiled tests for case when there is no x-tile

Cavitt, Jonathan jonathan.cavitt at intel.com
Wed Dec 18 22:05:33 UTC 2024


-----Original Message-----
From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Clint Taylor
Sent: Wednesday, December 18, 2024 1:37 PM
To: igt-dev at lists.freedesktop.org
Subject: [PATCH i-g-t v5 5/7] tests/intel/kms_draw_crc: fix x-tiled tests for case when there is no x-tile
> 
> From: Juha-pekka Heikkila <juha-pekka.heikkila at intel.com>
> 
> On Xe3 display no more support x-tile and will disable such framebuffers
> 
> v2: Optimize display_ver check (Sai Teja)
> 
> Signed-off-by: Juha-pekka Heikkila <juha-pekka.heikkila at intel.com>
> Signed-off-by: Clint Taylor <Clinton.A.Taylor at intel.com>

LGTM.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  tests/intel/kms_draw_crc.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/intel/kms_draw_crc.c b/tests/intel/kms_draw_crc.c
> index e3d1c0ba9..7d1cc2da5 100644
> --- a/tests/intel/kms_draw_crc.c
> +++ b/tests/intel/kms_draw_crc.c
> @@ -243,8 +243,10 @@ static void fill_fb_subtest(void)
>  	get_fill_crc(DRM_FORMAT_MOD_LINEAR, &crc);
>  	igt_assert_crc_equal(&crc, &base_crc);
>  
> -	get_fill_crc(I915_FORMAT_MOD_X_TILED, &crc);
> -	igt_assert_crc_equal(&crc, &base_crc);
> +	if (igt_display_has_format_mod(&display, DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED)) {
> +		get_fill_crc(I915_FORMAT_MOD_X_TILED, &crc);
> +		igt_assert_crc_equal(&crc, &base_crc);
> +	}
>  
>  	if (intel_display_ver(intel_get_drm_devid(drm_fd)) >= 9) {
>  		get_fill_crc(has_4tile ?
> -- 
> 2.25.1
> 
> 


More information about the igt-dev mailing list