[PATCH i-g-t v5 6/7] tests/kms_cursor_legacy: flip_vs_cursor_busy_crc was requiring any driver but used intel x-tile

[Cavitt, Jonathan]

-----Original Message-----
From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Clint Taylor
Sent: Wednesday, December 18, 2024 1:37 PM
To: igt-dev at lists.freedesktop.org
Subject: [PATCH i-g-t v5 6/7] tests/kms_cursor_legacy: flip_vs_cursor_busy_crc was requiring any driver but used intel x-tile
> 
> From: Juha-pekka Heikkila <juha-pekka.heikkila at intel.com>
> 
> switch flip_vs_cursor_busy_crc to use linear framebuffer instead of x-tile. Xe3 not longer supports x-tiled modifier.
> 
> Signed-off-by: Juha-pekka Heikkila <juha-pekka.heikkila at intel.com>
> Signed-off-by: Clint Taylor <Clinton.A.Taylor at intel.com>
> ---
>  tests/kms_cursor_legacy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index 4e2cfde17..1f082df2d 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -1679,7 +1679,7 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
>  	set_fb_on_crtc(display, pipe, output, &fb_info[0]);
>  	plane_primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
>  	igt_create_color_pattern_fb(display->drm_fd, fb_info[0].width, fb_info[0].height,
> -				    DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED, .1, .1, .1, &fb_info[1]);
> +				    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, .1, .1, .1, &fb_info[1]);

TBH, I don't know if we want to unconditionally switch over from using I915_FORMAT_MOD_X_TILED
to using DRM_FORMAT_MOD_LINEAR.  We may want to continue testing the former for legacy support
purposes, if for no other reason.  Though I'm also not particularly familiar with the KMS system, so
perhaps there's little reason for us to continue testing the old format?

I'll leave that to your discretion.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

>  
>  	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>  			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
> -- 
> 2.25.1
> 
>