[PATCH i-g-t v2 1/3] lib/igt_kmod: fix check to confirm correct driver unload

Lucas De Marchi lucas.demarchi at intel.com
Thu Dec 19 23:21:09 UTC 2024


On Thu, Dec 19, 2024 at 03:05:15PM -0800, Daniele Ceraolo Spurio wrote:
>The driver variable is a string, so we need to pass it in as a variable
>for the driver name instead of stringifying it.
>
>Fixes: e5edf7ea7 ("lib/igt_kmod: add support for Xe driver")
>Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
>Cc: Mauro Carvalho Chehab <mchehab at kernel.org>
>Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
>Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

yeah, also got it:
https://patchwork.freedesktop.org/patch/625232/?series=141532&rev=1

"Now that xe unbind+unload logic is working, extend it to i915.
Note that there was a buggy call igt_kmod_is_loaded("driver") that would
never trigger: no point fixing that if we are dropping it though."

unfortunately that got blocked in other issues and I forgot to extract
this part

Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi


More information about the igt-dev mailing list