[PATCH i-g-t] tests/intel/kms_flip_scaled_crc: Add more logs to skips/failure

B, Jeevan jeevan.b at intel.com
Fri Dec 20 04:58:19 UTC 2024


> -----Original Message-----
> From: Samala, Pranay <pranay.samala at intel.com>
> Sent: Friday, December 20, 2024 9:01 AM
> To: igt-dev at lists.freedesktop.org
> Cc: B S, Karthik <karthik.b.s at intel.com>; B, Jeevan <jeevan.b at intel.com>;
> Lattannavar, Sameer <sameer.lattannavar at intel.com>; Samala, Pranay
> <pranay.samala at intel.com>
> Subject: [PATCH i-g-t] tests/intel/kms_flip_scaled_crc: Add more logs to
> skips/failure
> 
> Having some logs for test failures and skips would make debugging much
> easier.
> 
> Signed-off-by: Pranay Samala <pranay.samala at intel.com>
> ---
>  tests/intel/kms_flip_scaled_crc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/kms_flip_scaled_crc.c
> b/tests/intel/kms_flip_scaled_crc.c
> index 7dc07bc83..7c66ce398 100644
> --- a/tests/intel/kms_flip_scaled_crc.c
> +++ b/tests/intel/kms_flip_scaled_crc.c
> @@ -633,7 +633,7 @@ static void test_flip_to_scaled(data_t *data, uint32_t
> index,
>  		igt_plane_set_prop_enum(primary,
> IGT_PLANE_SCALING_FILTER,
>  					kmstest_scaling_filter_str(flags));
>  	} else {
> -		igt_debug("Plane scaling filter prop not supported on gen <
> 11, running with default\n");
> +		igt_info("Plane scaling filter prop not supported on gen < 11,
> +running with default\n");


Is this check really failing the test so that changing the log from warn to info helps or is this just a note for users to know ?? 
@Sharma, Swati2 please comment your thoughts on this. 
>From me this change really doesn't add and value. Its ok to have I think.  
>  	}
> 
>  	igt_skip_on_f(!igt_plane_has_format_mod(primary, data-
> >small_fb.drm_format, data->small_fb.modifier) ||
> --
> 2.34.1



More information about the igt-dev mailing list