[PATCH i-g-t] tests/kms_lease: Add vblank count to avoind resource busy

Samala, Pranay pranay.samala at intel.com
Fri Dec 20 05:38:22 UTC 2024


Hi Thasleem,

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
> Mohammed Thasleem
> Sent: Thursday, December 19, 2024 10:10 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Nautiyal, Ankit K <ankit.k.nautiyal at intel.com>; Thasleem, Mohammed
> <mohammed.thasleem at intel.com>
> Subject: [PATCH i-g-t] tests/kms_lease: Add vblank count to avoind resource
> busy
> 
> Add vblank count to avoind resource busy so that page flip to be happen
Avoid, Typo error.
> without any sync issue while setting a mode on leased output.
> 
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem at intel.com>
> ---
>  tests/kms_lease.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c index 0f3a68fed..0fbf5b0ba
> 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -378,8 +378,8 @@ static void page_flip_implicit_plane(data_t *data)
> 
>  	display = &data->master.display;
> 
> -	igt_wait_for_vblank(data->master.fd,
> -			display->pipes[pipe].crtc_offset);
> +	igt_wait_for_vblank_count(data->master.fd,
> +				  display->pipes[pipe].crtc_offset, 2);

Why are we hardcoding as 2? And in which context(time/frame) you are using this 2? 
Will these changes work on 4 pipes also?

Regards,
Pranay Samala
> 
>  	do_or_die(drmModePageFlip(data->lease.fd, data->crtc_id,
>  			      data->master.primary_fb.fb_id,
> --
> 2.25.1



More information about the igt-dev mailing list