[PATCH i-g-t v3 3/5] lib/monitor_edids: Add helper to print all available EDID names

[Kamil Konieczny]

Hi Louis,
On 2024-11-22 at 16:51:36 +0100, Louis Chauvet wrote:
> During the chamelium v3 configuration, it may be required to know the list
> of supported EDID names, so add an helper to print them.
> 
> Signed-off-by: Louis Chauvet <louis.chauvet at bootlin.com>
> ---
>  lib/monitor_edids/monitor_edids_helper.c | 15 +++++++++++++++
>  lib/monitor_edids/monitor_edids_helper.h |  2 ++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/lib/monitor_edids/monitor_edids_helper.c b/lib/monitor_edids/monitor_edids_helper.c
> index 4d739937ede1e8f09eb6e8bf225f047d5c3dfd04..9de8aa06a45c164e928ae3821f841414b437eaac 100644
> --- a/lib/monitor_edids/monitor_edids_helper.c
> +++ b/lib/monitor_edids/monitor_edids_helper.c
> @@ -195,3 +195,18 @@ struct edid *get_edid_by_name(char *name)
>  
>  	return NULL;
>  }
> +
> +
> +/*

Start with '/**'

With this
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> + * list_edid_names() - Print all the EDID available in igt
> + * @level: Log level to write the names on
> + */
> +void list_edid_names(enum igt_log_level level)
> +{
> +	for (int i = 0; i < ARRAY_SIZE(ALL_EDIDS); i++) {
> +		for (int j = 0; j < ALL_EDIDS[i].list_size; j++) {
> +			igt_log(IGT_LOG_DOMAIN, level, " - \"%s\"\n",
> +				ALL_EDIDS[i].edid_list[j].name);
> +		}
> +	}
> +}
> diff --git a/lib/monitor_edids/monitor_edids_helper.h b/lib/monitor_edids/monitor_edids_helper.h
> index a45dca870eb20f66c9472be6643019d23bc18b9a..04a639f47b49ab176e914f6044bba6769dc84ccb 100644
> --- a/lib/monitor_edids/monitor_edids_helper.h
> +++ b/lib/monitor_edids/monitor_edids_helper.h
> @@ -15,6 +15,7 @@
>  #include <stddef.h>
>  #include <stdbool.h>
>  
> +#include "igt_core.h"
>  #include "igt_chamelium.h"
>  
>  /* Max Length can be increased as needed, when new EDIDs are added. */
> @@ -35,5 +36,6 @@ void free_chamelium_edid_from_monitor_edid(struct chamelium_edid *edid);
>  struct edid *edid_from_monitor_edid(const monitor_edid *monitor_edid);
>  struct monitor_edid *get_edids_for_connector_type(uint32_t type, size_t *count, bool four_k);
>  struct edid *get_edid_by_name(char *name);
> +void list_edid_names(enum igt_log_level level);
>  
>  #endif /* TESTS_CHAMELIUM_MONITOR_EDIDS_MONITOR_EDIDS_HELPER_H_ */
> 
> -- 
> 2.47.0
>