[PATCH i-g-t 3/3] lib/igt_sysfs: Fix dir fd documentation

Kamil Konieczny kamil.konieczny at linux.intel.com
Thu Feb 1 13:05:59 UTC 2024


Hi Lucas,
On 2024-01-31 at 16:50:30 -0800, Lucas De Marchi wrote:
> These functions can be used for any path in sysfs, not exclusively to
> attributes under igt_sysfs_open(). In fact, they are already used to
> access other files like module parameters.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  lib/igt_sysfs.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c
> index 814220ddb..bbcb16c81 100644
> --- a/lib/igt_sysfs.c
> +++ b/lib/igt_sysfs.c
> @@ -343,7 +343,7 @@ int igt_sysfs_get_num_gt(int device)
>  
>  /**
>   * igt_sysfs_write:
> - * @dir: directory for the device from igt_sysfs_open()
> + * @dir: sysfs directory
>   * @attr: name of the sysfs node to open
>   * @data: the block to write from
>   * @len: the length to write
> @@ -369,7 +369,7 @@ int igt_sysfs_write(int dir, const char *attr, const void *data, int len)
>  
>  /**
>   * igt_sysfs_read:
> - * @dir: directory for the device from igt_sysfs_open()
> + * @dir: sysfs directory
>   * @attr: name of the sysfs node to open
>   * @data: the block to read into
>   * @len: the maximum length to read
> @@ -395,7 +395,7 @@ int igt_sysfs_read(int dir, const char *attr, void *data, int len)
>  
>  /**
>   * igt_sysfs_set:
> - * @dir: directory for the device from igt_sysfs_open()
> + * @dir: sysfs directory
>   * @attr: name of the sysfs node to open
>   * @value: the string to write
>   *
> @@ -412,7 +412,7 @@ bool igt_sysfs_set(int dir, const char *attr, const char *value)
>  
>  /**
>   * igt_sysfs_get:
> - * @dir: directory for the device from igt_sysfs_open()
> + * @dir: sysfs directory
>   * @attr: name of the sysfs node to open
>   *
>   * This reads the value from the sysfs file.
> -- 
> 2.43.0
> 


More information about the igt-dev mailing list