[PATCH i-g-t 2/2] xe_live_ktest: Use xe_live_test kernel module

Janusz Krzysztofik janusz.krzysztofik at linux.intel.com
Mon Feb 5 09:28:45 UTC 2024


On Friday, 2 February 2024 16:25:56 CET Lucas De Marchi wrote:
> On Fri, Feb 02, 2024 at 01:00:14PM +0100, Janusz Krzysztofik wrote:
> >On Friday, 2 February 2024 01:45:29 CET Lucas De Marchi wrote:
> >> https://patchwork.freedesktop.org/series/126786/ groups all the live
> >> tests into a single kernel module. Use that module to run any of the
> >> tests triggered by igt.
> >>
> >> To make the live kunit tests work, rename the subtests so they match
> >> what the kernel uses.
> >
> >Both the KUnit module name and the IGT test name clearly indicate they are
> 
> kunit is usable without igt and I'd like to continue it like that, so

I didn't say there was something wrong with that.

> what remains is the kunit module name. But then that would imply using
> both filter and filter_glob rather than simply using just filter_glob.
> 
> >strictly related to Xe.  Then, I think that shorter subtest names, without the
> >xe_ prefix, are better in that narrow name space.  Couldn't we then rename
> >test suits on the kernel side instead of adding that redundant prefix also to
> >IGT subtest names?
> 
> I don't think it's a good alternative because the test suite names are
> global, regardless what module it comes from. For all the live tests,

You're right, our xe test suites names are in line with KUnit style 
recommendations.

Thanks,
Janusz

> they were always prefixed with xe_. We do have some normal kunit without
> prefix, but I´d rather add the prefix there than remove here.
> 
> Lucas De Marchi
> 






More information about the igt-dev mailing list