[PATCH i-g-t] lib/xe/xe_query: Print L3 bank and node masks

[Kamil Konieczny]

Hi Francois,
On 2024-01-26 at 15:51:29 +0000, Francois Dugast wrote:
> L3 bank and node masks have been added to the uAPI, so print them in
> the topology query test. This aligns to kernel commit ("drm/xe: Add
> L3 bank and node masks to topology query").

Could we have it other way, e.g. more important is a change
in drm-uapi, not in lib for test, also it is incorrect now:

[PATCH i-g-t] lib/xe/xe_query: Print L3 bank and node masks
------------- ^^^^^^^^^^^^^^^
and files changed are:

include/drm-uapi/xe_drm.h | 2 ++
tests/intel/xe_query.c    | 2 ++

So I would suggest something like:

drm-uapi/xe: add L3 bank topology

btw is the kernel commit you refer to in drm-next?
It would help if you provide also http link,

Regards,
Kamil

> 
> Signed-off-by: Francois Dugast <francois.dugast at intel.com>
> ---
>  include/drm-uapi/xe_drm.h | 2 ++
>  tests/intel/xe_query.c    | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
> index bacdca787..170cc0de9 100644
> --- a/include/drm-uapi/xe_drm.h
> +++ b/include/drm-uapi/xe_drm.h
> @@ -513,6 +513,8 @@ struct drm_xe_query_topology_mask {
>  #define DRM_XE_TOPO_DSS_GEOMETRY	(1 << 0)
>  #define DRM_XE_TOPO_DSS_COMPUTE		(1 << 1)
>  #define DRM_XE_TOPO_EU_PER_DSS		(1 << 2)
> +#define DRM_XE_TOPO_L3_BANK		(1 << 3)
> +#define DRM_XE_TOPO_L3_NODE		(1 << 4)
>  	/** @type: type of mask */
>  	__u16 type;
>  
> diff --git a/tests/intel/xe_query.c b/tests/intel/xe_query.c
> index 9a6799c84..0a754f51c 100644
> --- a/tests/intel/xe_query.c
> +++ b/tests/intel/xe_query.c
> @@ -166,6 +166,8 @@ const char *get_topo_name(int value)
>  	case DRM_XE_TOPO_DSS_GEOMETRY: return "DSS_GEOMETRY";
>  	case DRM_XE_TOPO_DSS_COMPUTE: return "DSS_COMPUTE";
>  	case DRM_XE_TOPO_EU_PER_DSS: return "EU_PER_DSS";
> +	case DRM_XE_TOPO_L3_BANK: return "L3_BANK";
> +	case DRM_XE_TOPO_L3_NODE: return "L3_NODE";
>  	}
>  	return "??";
>  }
> -- 
> 2.34.1
>