[i-g-t] tests/intel/xe_exec_queue_property: Remove persistence queue property

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon Feb 5 17:46:47 UTC 2024


Hi Tejas,
On 2024-02-05 at 11:32:25 +0530, Tejas Upadhyay wrote:
> KMD has removed support setting persistence queue property
> here https://patchwork.freedesktop.org/series/129311/, to
------------------------------------------------------ ^

Please do not add any chars at end of http link.

> have parity remove test support as well

Also I would expect info about drm-uapi change in subject,
instead of:

[i-g-t] tests/intel/xe_exec_queue_property: Remove persistence queue property

I would suggest:

[PATCH v1 i-g-t] drm-uapi/xe: remove persistence queue

+cc Ashutosh

Regards,
Kamil

> 
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
> ---
>  include/drm-uapi/xe_drm.h            | 9 ++++-----
>  tests/intel/xe_exec_queue_property.c | 8 --------
>  2 files changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
> index bacdca787..1917e4c50 100644
> --- a/include/drm-uapi/xe_drm.h
> +++ b/include/drm-uapi/xe_drm.h
> @@ -1046,11 +1046,10 @@ struct drm_xe_exec_queue_create {
>  #define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY		0
>  #define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_TIMESLICE		1
>  #define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_PREEMPTION_TIMEOUT	2
> -#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_PERSISTENCE		3
> -#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_JOB_TIMEOUT		4
> -#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_ACC_TRIGGER		5
> -#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_ACC_NOTIFY		6
> -#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_ACC_GRANULARITY	7
> +#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_JOB_TIMEOUT		3
> +#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_ACC_TRIGGER		4
> +#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_ACC_NOTIFY		5
> +#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_ACC_GRANULARITY	6
>  /* Monitor 128KB contiguous region with 4K sub-granularity */
>  #define     DRM_XE_ACC_GRANULARITY_128K				0
>  /* Monitor 2MB contiguous region with 64KB sub-granularity */
> diff --git a/tests/intel/xe_exec_queue_property.c b/tests/intel/xe_exec_queue_property.c
> index 53e08fb0e..4fdd4ceae 100644
> --- a/tests/intel/xe_exec_queue_property.c
> +++ b/tests/intel/xe_exec_queue_property.c
> @@ -11,8 +11,6 @@
>   * Test category: functionality test
>   * SUBTEST: priority-set-property
>   * Description: tests basic priority property by setting invalid values and positive values.
> - * SUBTEST: persistence-set-property
> - * Description: tests basic persistence property by setting positive values
>   * SUBTEST: %s-property-min-max
>   * Description: Test to check if %s arg[1] schedule parameter checks for min max values.
>   *
> @@ -214,12 +212,6 @@ igt_main
>  		igt_waitchildren();
>  	}
>  
> -	igt_subtest("persistence-set-property") {
> -		/* Tests persistence property by setting positive values. */
> -		test_set_property(xe, DRM_XE_EXEC_QUEUE_SET_PROPERTY_PERSISTENCE, 1, 0);
> -
> -	}
> -
>  	igt_subtest_group {
>  		igt_fixture {
>  			sys_fd = igt_sysfs_open(xe);
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list