[i-g-t] tests/intel/xe_exec_queue_property: Remove persistence queue property

Lucas De Marchi lucas.demarchi at intel.com
Mon Feb 5 18:30:37 UTC 2024


On Mon, Feb 05, 2024 at 05:56:46AM +0000, Dandamudi, Priyanka wrote:
>> -----Original Message-----
>> From: Upadhyay, Tejas <tejas.upadhyay at intel.com>
>> Sent: Monday, February 5, 2024 11:32 AM
>> To: igt-dev at lists.freedesktop.org
>> Cc: Dandamudi, Priyanka <priyanka.dandamudi at intel.com>; Upadhyay, Tejas
>> <tejas.upadhyay at intel.com>
>> Subject: [i-g-t] tests/intel/xe_exec_queue_property: Remove persistence
>> queue property
>>
>> KMD has removed support setting persistence queue property here
>> https://patchwork.freedesktop.org/series/129311/, to have parity remove test

wrong link, should reference the patch by Thomas. Either
20240130125220.5517-1-thomas.hellstrom at linux.intel.com or the new
version

>> support as well
>>
>> Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
>> ---
>>  include/drm-uapi/xe_drm.h            | 9 ++++-----
>>  tests/intel/xe_exec_queue_property.c | 8 --------
>>  2 files changed, 4 insertions(+), 13 deletions(-)
>>
>> diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h index
>> bacdca787..1917e4c50 100644
>> --- a/include/drm-uapi/xe_drm.h
>> +++ b/include/drm-uapi/xe_drm.h
>> @@ -1046,11 +1046,10 @@ struct drm_xe_exec_queue_create {
>>  #define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY		0
>>  #define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_TIMESLICE		1
>>  #define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_PREEMPTION_TIMEOUT
>> 	2
>> -#define   DRM_XE_EXEC_QUEUE_SET_PROPERTY_PERSISTENCE
>> 	3
>I see from the KMD patch they are renaming.
>DRM_XE_EXEC_QUEUE_SET_PROPERTY_PERSISTENCE to DRM_XE_EXEC_QUEUE_SET_PROPERTY_UNUSED_1
>Can you please check this?

The file include/drm-uapi/xe_drm.h shouldn't really be
modified by igt as it's a pain to keep it in sync this way. Instead, it
should be a straight copy from the kernel source when it changes.... so
whatever is in the v2 of the patch by Thomas should be the one here. Or
just leave the header alone and let it be sync'ed next time it's needed.

Lucas De Marchi


More information about the igt-dev mailing list