[PATCH i-g-t] lib: Add ARL-S PCI ID for perf tests

[Borah, Chaitanya Kumar]

Hello Ashutosh,

> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit at intel.com>
> Sent: Monday, February 5, 2024 10:08 PM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>
> Cc: igt-dev at lists.freedesktop.org; Nerlige Ramappa, Umesh
> <umesh.nerlige.ramappa at intel.com>
> Subject: Re: [PATCH i-g-t] lib: Add ARL-S PCI ID for perf tests
> 
> On Sun, 04 Feb 2024 22:01:39 -0800, Chaitanya Kumar Borah wrote:
> >
> 
> Hi Chaitanya,
> 
> > Enable perf tests on ARL-S
> >
> > Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah at intel.com>
> > ---
> >  lib/i915_pciids_local.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/i915_pciids_local.h b/lib/i915_pciids_local.h index
> > a0ca29ee7..0043b0cd9 100644
> > --- a/lib/i915_pciids_local.h
> > +++ b/lib/i915_pciids_local.h
> > @@ -10,7 +10,8 @@
> >  /* MTL perf */
> >  #ifndef INTEL_MTL_M_IDS
> >  #define INTEL_MTL_M_IDS(info) \
> > -	INTEL_VGA_DEVICE(0x7D60, info)
> > +	INTEL_VGA_DEVICE(0x7D60, info), \
> > +	INTEL_VGA_DEVICE(0x7D67, info)
> 
> 1. Did you check if this fixes the OA tests on ARL? Or this will enable
>    the testing?
> 

Yes, we verified locally. After the PCI-ID is added the perf tests are executing successfully.

> 2. Why not include all ARL PCI ID's? Seem to be already there in kernel
>    include/drm/i915_pciids.h. Also:
> 
>    https://gfxspecs.intel.com/Predator/Home/Index/55420
> 

I was looking at it from only ARL-S perspective.
+Haridhar is looking into ARL-H.

> 3. How about moving all these MTL/ARL ID's into lib/i915_pciids.h from
>    lib/i915_pciids_local.h?
> 

The perf test needs differentiations between PCI-IDs that lib/i915_pciids.h does not provide. Therefore we maintain separate macros in lib/i915_pciids_local.h.

Please refer to the conversation here.

https://lore.kernel.org/all/7297abc4-309a-4ca8-a606-498b3abd0c2a@intel.com/

Thank you.

Regards

Chaitanya


> Thanks.
> --
> Ashutosh