[PATCH i-g-t v3 4/8] scripts/igt_doc.py: only create dict if subtest will be added

[Kamil Konieczny]

Hi Mauro,
On 2024-02-09 at 13:34:43 +0100, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> Currently, depending on the order of the sets/dict, some
> empty testlists are created. Change the logic to only add
> an entry into the dict if a subtest will be added to it.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  scripts/igt_doc.py | 34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/scripts/igt_doc.py b/scripts/igt_doc.py
> index 8a10db13081c..1c2c7a8ef973 100755
> --- a/scripts/igt_doc.py
> +++ b/scripts/igt_doc.py
> @@ -116,31 +116,31 @@ class IgtTestList(TestList):
>                      run_type = "other"
>  
>                  for subname, gpus in subnames.items():
> -                    if not gpu_set:
> -                        gpu = "default"
> -
> -                    if gpu not in testlists[driver]:
> -                        testlists[driver][gpu] = {}
> -
> -                    if run_type not in testlists[driver][gpu]:
> -                        testlists[driver][gpu][run_type] = set()
> -
> -                    # Trivial case: fields not defined
> -                    if not gpu_set:
> -                        testlists[driver][gpu][run_type].add(subname)
> -                        continue
> -
> -                    # Globally blocklisted values
> +                    # Globally blocklisted values: ignore subtest
>                      if "all" in tests_per_list[driver][run_type][subname]:
>                          continue
>  
> -                    # Nothing blocked of explicitly added.
> -                    # It means that test should be on testlists
> +                    if not gpu_set:
> +                        gpu = "default"
> +
> +                    # Trivial case: fields not defined: add subtest
> +                    if not gpu_set:
> +                        if gpu not in testlists[driver]:
> +                            testlists[driver][gpu] = {}
> +
> +                        if run_type not in testlists[driver][gpu]:
> +                            testlists[driver][gpu][run_type] = set()
> +
> +                        testlists[driver][gpu][run_type].add(subname)
> +                        continue
> +
>                      if not gpus:
>                          for gpu in gpu_set:
> +                            # blocked on all GPUs: ignore subtest
>                              if gpu == "all":
>                                  continue
>  
> +                            # Nothing blocked: add subtest
>                              if gpu not in testlists[driver]:
>                                  testlists[driver][gpu] = {}
>  
> -- 
> 2.43.0
>