[PATCH i-g-t v3 6/8] scripts/igt_doc.py: remove some unused logic

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Feb 9 13:10:34 UTC 2024


Hi Mauro,
On 2024-02-09 at 13:34:45 +0100, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> There's no need to check for empty string anymore, as the logic
> at gen_intelci_testlist() already ensures that missing run types
> are associated with "other" The same applies to GPUs, whose
---------------------------- ^
Put dot here, after "other".

With that fixed,

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> default is "default".
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>
> ---
>  scripts/igt_doc.py | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/scripts/igt_doc.py b/scripts/igt_doc.py
> index fd1960dac6e0..bf51e5f4ebb3 100755
> --- a/scripts/igt_doc.py
> +++ b/scripts/igt_doc.py
> @@ -231,11 +231,8 @@ class IntelciTestlist:
>                      pass
>  
>                  for testlist, subtests in names.items():
> -                    if testlist == "":
> -                        testlist = "other"
> -                    else:
> -                        testlist = re.sub(r"[\W_]+", "-", testlist).lower()
> -                        testlist = re.sub(r"_+", "_", testlist)
> +                    testlist = re.sub(r"[\W_]+", "-", testlist).lower()
> +                    testlist = re.sub(r"_+", "_", testlist)
>  
>                      if not subtests:
>                          if testlist != "other":
> -- 
> 2.43.0
> 


More information about the igt-dev mailing list