[PATCH i-g-t 6/8] tests/intel/kms_dirtyfb: pass the bo_size

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Mon Feb 12 14:58:57 UTC 2024


On Fri, Feb 09, 2024 at 06:34:31PM +0000, Matthew Auld wrote:
> Looks possible for the derived bo_size to not be page aligned leading to
> broken behaviour when vm_binding it. Pass through the real bo_size,
> instead of leaving as zero. This will be enforced in the next patch.
> 
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> ---
>  tests/intel/kms_dirtyfb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> index 7bf49cb15..26b82e50a 100644
> --- a/tests/intel/kms_dirtyfb.c
> +++ b/tests/intel/kms_dirtyfb.c
> @@ -254,7 +254,7 @@ static void run_test(data_t *data)
>  				    igt_drm_format_to_bpp(data->fbs[1].drm_format),
>  				    0,
>  				    igt_fb_mod_to_tiling(data->fbs[1].modifier),
> -				    0, 0, 0, is_xe_device(data->drm_fd) ?
> +				    0, data->fbs[1].size, 0, is_xe_device(data->drm_fd) ?
>  				    system_memory(data->drm_fd) : 0,
>  				    intel_get_pat_idx_uc(data->drm_fd));
>  	dst = intel_buf_create_full(data->bops, data->fbs[2].gem_handle,
> @@ -262,7 +262,7 @@ static void run_test(data_t *data)
>  				    data->fbs[2].height,
>  				    igt_drm_format_to_bpp(data->fbs[2].drm_format),
>  				    0, igt_fb_mod_to_tiling(data->fbs[2].modifier),
> -				    0, 0, 0, is_xe_device(data->drm_fd) ?
> +				    0, data->fbs[2].size, 0, is_xe_device(data->drm_fd) ?
>  				    system_memory(data->drm_fd) : 0,
>  				    intel_get_pat_idx_uc(data->drm_fd));
>  	ibb = intel_bb_create(data->drm_fd, PAGE_SIZE);
> -- 
> 2.43.0
> 

LGTM:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew


More information about the igt-dev mailing list