[PATCH v2 1/1] tests/kms_plane: Restricting number of pixel formats for simulation

[Juha-Pekka Heikkila]

Hi Pranay,

On 14.2.2024 10.53, Samala, Pranay wrote:
> The pixel-format subtest runs on all pixel formats, reducing it to single
> format to reduce execution time on simulation.
> 
> Cc: B S, Karthik <karthik.b.s at intel.com>
> Cc: B, Jeevan <jeevan.b at intel.com>
> 
> Signed-off-by: Samala, Pranay <pranay.samala at intel.com>
> ---
>   tests/kms_plane.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 406aecc04..fbffc3cb0 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -1081,6 +1081,9 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
>   		    f.modifier == ref.modifier)
>   			continue;
>   
> +		if (f.format != DRM_FORMAT_XRGB8888 && igt_run_in_simulation())
> +			continue;
> +

I don't think this is very good move when idea of this test is to try 
out pixel formats. This test will secure the plumbing for these 
different pixel formats will stay good hence at least for each bpp and 
planar groups should run some test. With this change would be checked 
reference format matches with itself.

/Juha-Pekka

>   		/* test each format "class" only once in non-extended tests */
>   		if (!data->extended && f.modifier != DRM_FORMAT_MOD_LINEAR) {
>   			struct format_mod rf = {