[PATCH i-g-t v4 4/8] lib/kunit: Support writable filter* parameters of kunit module

[Lucas De Marchi]

On Fri, Feb 09, 2024 at 01:11:39PM +0100, Janusz Krzysztofik wrote:
>Hi Lucas,
>
>On Tuesday, 6 February 2024 11:00:28 CET Janusz Krzysztofik wrote:
>> Instead of wasting resources on reloading the base Kunit module each time
>> a different set of filter parameters is needed, try to write the required
>> values to sysfs representation of those parameters.
>>
>> This modification will also serve as a workaround for the issue of
>> impossibility to unload the base Kunit module on Xe platforms, available
>> to IGT as soon as the module supports writable filter parameters.
>>
>> v4: Return early when opening module parameters directory fails (Lucas),
>>   - use error unwind pattern on errors from sysfs writes,
>>   - replace "human-readable" with "non-NULL" in comments about strings
>>     used as equivalents of default NULLs,
>>   - use empty string as filter_action NULL equivalent, but verify if
>>     successfully applied when critical,
>>   - refresh commit description by removing a statement that addressed an
>>     update to a comment on legacy path, no longer in scope of this patch.
>
>With your closing statement in your initial comments to v3:
>"... if this works, seems ok for now."
>(https://patchwork.freedesktop.org/patch/576817/?series=129174&rev=3#comment_1052127)
>you seemed to accept v3 of this patch even if you had some ideas for further
>updates.  In v4 I tried to address those ideas, one way or another (please see
>v4 cover letter for more information).  Since you haven't commented that new
>version, may I assume you are OK with it?

yes, please go ahead with this if it's working. Further changes can be
done on top.


Lucas De Marchi